Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAIIFree functions have wrong type #1892

Closed
kennykerr opened this issue Apr 30, 2024 · 2 comments
Closed

RAIIFree functions have wrong type #1892

kennykerr opened this issue Apr 30, 2024 · 2 comments
Labels
rust Critical for Rust adoption

Comments

@kennykerr
Copy link
Contributor

  • COMPRESSOR_HANDLE's free function is CloseDecompressor and it should probably expect a COMPRESSOR_HANDLE parameter type instead of IntPtr.

  • WSAEVENT's free function is WSACloseEvent and it should probably expect a WSAEVENT parameter type instead of HANDLE.
@kennykerr kennykerr mentioned this issue Apr 30, 2024
Merged
@riverar
Copy link
Collaborator

riverar commented Apr 30, 2024

Note: COMPRESSOR_HANDLE should be tied to CloseCompressor, not CloseDecompressor

@riverar riverar added the rust Critical for Rust adoption label Apr 30, 2024
@mikebattista
Copy link
Contributor

WSAEVENT is #1587.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rust Critical for Rust adoption
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@riverar @kennykerr @mikebattista