ReadConsoleW does not have SetLastError=true

[alexrp]

Actual behavior

[DllImport("Kernel32", ExactSpelling = true)]
[DefaultDllImportSearchPaths(DllImportSearchPath.System32)]
internal static extern unsafe win32.Foundation.BOOL ReadConsoleW(win32.Foundation.HANDLE hConsoleInput, void* lpBuffer, uint nNumberOfCharsToRead, uint* lpNumberOfCharsRead, [Optional] win32.System.Console.CONSOLE_READCONSOLE_CONTROL* pInputControl);

Expected behavior

[DllImport("Kernel32", ExactSpelling = true, SetLastError = true)]
[DefaultDllImportSearchPaths(DllImportSearchPath.System32)]
internal static extern unsafe win32.Foundation.BOOL ReadConsoleW(win32.Foundation.HANDLE hConsoleInput, void* lpBuffer, uint nNumberOfCharsToRead, uint* lpNumberOfCharsRead, [Optional] win32.System.Console.CONSOLE_READCONSOLE_CONTROL* pInputControl);

Repro steps

1. NativeMethods.txt content:

ReadConsoleW

2. NativeMethods.json content (if present):

{
  "$schema": "https://raw.githubusercontent.com/microsoft/CsWin32/main/src/Microsoft.Windows.CsWin32/settings.schema.json",
  "wideCharOnly": false,
  "emitSingleFile": true
}

Context

• CsWin32 version: 0.1.588-beta
• Win32Metadata version (if explicitly set by project): 15.0.2-preview
• Target Framework: net6.0
• LangVersion (if explicitly set by project): preview

[alexrp]

It's probably not helpful to open a new issue for every related API, so I'll note here that the following functions have the same issue:

• FlushConsoleInputBuffer
• GetConsoleMode
• GetConsoleScreenBufferInfo
• SetConsoleMode
• SetConsoleCP
• SetConsoleOutputCP

It seems like it might be a pervasive issue with console-related APIs.

(I'm working around it by using Marshal.GetLastSystemError for now.)