Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cross compilation in CI #1799

Closed
est31 opened this issue Jun 3, 2022 · 10 comments · Fixed by #1808
Closed

Test cross compilation in CI #1799

est31 opened this issue Jun 3, 2022 · 10 comments · Fixed by #1808
Labels
enhancement New feature or request

Comments

@est31
Copy link

est31 commented Jun 3, 2022

When skimming over the github actions CI, I couldn't see any build hosts on ubuntu or mac OS. So right now, even though #638 is closed, it could regress any time. Therefore, it would be good to test cross compilation in the CI.

The reason for filing is that I'm getting PRs by people trying to switch from winapi to windows-rs but I want people to still be able to target the windows platform from their non-windows computers. Thanks!

@kennykerr
Copy link
Collaborator

I don't have any experience with cross-compilation in Rust but happy to review a PR with a separate yml script that provides basic cross-compilation testing.

@kennykerr kennykerr added the enhancement New feature or request label Jun 3, 2022
@est31
Copy link
Author

est31 commented Jun 3, 2022

@kennykerr I suppose such a PR requires a CLA?

@kennykerr
Copy link
Collaborator

Yes, I think all the Microsoft repos require a CLA.

@est31
Copy link
Author

est31 commented Jun 3, 2022

@kennykerr we will have to wait for someone else to do it then, as I don't sign away copyrights without receiving money back. It's great news though that you welcome a PR to fix this issue :).

@riverar
Copy link
Collaborator

riverar commented Jun 3, 2022

Heads up: The CLA does not transfer copyright.

I can poke at this over the weekend; I'm looking forward to @est31 sponsoring me/that work! 😆 🤑

@est31
Copy link
Author

est31 commented Jun 4, 2022

@riverar that offer is very kind of you, but I have to politely decline. I don't receive sponsorships for my OSS work, so can't take some of that money to give it to you, and it is getting personal, but in my current employment in academia I don't have a lot of disposable income available either. I don't need it for my job, but so that I can switch OSS projects I'm maintaining to this crate (which seems to be better maintained than winapi). Maybe there is someone who can sponsor you instead, but it won't be me. I hope you understand.

@riverar
Copy link
Collaborator

riverar commented Jun 9, 2022

@est31 Added the start of a workflow for this. i686 is a challenge due to mingw being a mess across platforms but it's on my TODO list. I also recognize these are not true tests as we don't execute the output on a Windows machine but that's coming next. (I have manually verified macOS and Ubuntu generated executables run on Windows.)

@est31
Copy link
Author

est31 commented Jun 9, 2022

@riverar that's very amazing, thank you!

@tim-weis
Copy link
Contributor

tim-weis commented Jun 9, 2022

@riverar I'm curious, do you have a better way to test GitHub actions other than pushing any changes upstream, waiting for GitHub to report success/error, and start over from there?

@riverar
Copy link
Collaborator

riverar commented Jun 9, 2022

@tim-weis Not really, I just try to hide the mess in my own fork first. I haven't gotten around to building/hosting the agents locally--I think GitHub Actions team could do better at making these more accessible.

https://github.com/actions/virtual-environments/tree/main/images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants