Bug: windows_sys::Wdk::Foundation::DRIVER_OBJECT requires feature Win32_Graphics_DirectDraw

[wbenny]

Which crate is this about?

windows-sys

Crate version

0.48.0

Summary

windows_sys::Wdk::Foundation::DRIVER_OBJECT requires feature Win32_Graphics_DirectDraw, however that feature is missing in sys/Cargo.toml

Toolchain version/configuration

No response

Reproducible example

No response

Crate manifest

No response

Expected behavior

No response

Actual behavior

No response

Additional comments

No response

[wbenny]

The whole DirectDraw is missing in the sys crate.
For some reason, the pub struct MDL is expected there - and sure, in non-sys crate, the MDL struct is in there.

[kennykerr]

I first reported this issue here: microsoft/wdkmetadata#35

It looks like it might have been fixed, but windows-rs hasn't taken a Win32/Wdk metadata update in a while.

[wbenny]

Ah, good to know. Thanks!

Also, there are more discrepancies in the Wdk.

For example, in Wdk/Foundation, there is:
pub type PDRIVER_UNLOAD = ::core::option::Option<unsafe extern "system" fn() -> ()>;

but Wdk/System/SystemServices has:
pub type DRIVER_UNLOAD = ::core::option::Option<unsafe extern "system" fn(driverobject: *const super::super::Foundation::DRIVER_OBJECT) -> ()>;

also, driver dispatch routine seems off in Wdk/Foundation:
pub type PDRIVER_DISPATCH = ::core::option::Option<unsafe extern "system" fn() -> super::super::Win32::Foundation::NTSTATUS>; - it should accept DEVICE_OBJECT* and IRP* in the parameters.

Should I create separate issue for this, or is this addressed in the wdkmetadata already as well?

[kennykerr]

Yep if you are unsure feel free to open issues on the wdk repo.

[kennykerr]

#2573 updated the repo with the latest metadata. Please kick the tires and let me know if you experience any issues.

[wbenny]

Thanks! The issue with feature gate went away, though the discrepancy between PDRIVER_UNLOAD/PDRIVER_DISPATCH types is still there.

[kennykerr]

Please open an issue on the appropriate repo.