Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata and rebuild bindings #2571

Closed
eiderdaus opened this issue Jul 11, 2023 · 3 comments · Fixed by #2573
Closed

Update metadata and rebuild bindings #2571

eiderdaus opened this issue Jul 11, 2023 · 3 comments · Fixed by #2573

Comments

@eiderdaus
Copy link

microsoft/wdkmetadata#37 introduced some Nt* APIs. They are not yet available in either of windows or windows-sys crates. I guess the updated metadata needs to be imported here and the bindings regenerated.

Particularly I'd like NtCancelIoFileEx implemented so tokio-rs/mio#1632 can be fixed.

@kennykerr
Copy link
Collaborator

#2573 updated the repo with the latest metadata. Please kick the tires and let me know if you experience any issues.

@eiderdaus
Copy link
Author

Very well, I could patch my mio to use windows-sys' new NtCancelIoFileEx declaration, thanks! So once new crate versions are released here, mio's aforementioned bug can be fixed.

Though it took a little longer than expected because I had to look up a few imports that changed namespace (some from Win32 to Wdk no less), corroborating my suspicion that these namespaces are based on rather arbitrary naming decisions and no actual concept, but I digress.

@kennykerr
Copy link
Collaborator

Yes, my focus this year is on stabilizing metadata so that these somewhat subjective changes are a thing of the past and we can begin to stabilize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants