Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help menu opens browser instead of included HTML help file #184

Open
tomrow opened this issue Jun 11, 2018 · 3 comments · May be fixed by #211
Open

Help menu opens browser instead of included HTML help file #184

tomrow opened this issue Jun 11, 2018 · 3 comments · May be fixed by #211

Comments

@tomrow
Copy link

tomrow commented Jun 11, 2018

This command needs to be updated to accommodate the change from HLP to CHM.
@daniel-white
Copy link

CHMs are deprecated too :(

@tomrow
Copy link
Author

tomrow commented Jun 11, 2018 via email

@thecatkitty
Copy link
Contributor

In fact, there's no mention of the winfile.chm file in the source code!

AFAIK, the reason for that is the fact that the open-sourced WinFile is based on NT4 codebase which predates HTML Help format.

I could make a simple patch which would try to open CHM instead of HLP, but I would like to ask @craigwi if we plan to continue using CHMs in the first place. Maybe it's a good time to move to discrete HTML files and just call the browser instead?

@thecatkitty thecatkitty linked a pull request Jan 17, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use HTML Help instead of Windows Help thecatkitty/winfile
3 participants
@daniel-white @tomrow @thecatkitty