Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to upgrade (Apps that upgrade themselves) #1163

Closed
denelon opened this issue Jun 14, 2021 · 6 comments · Fixed by #1795
Closed

Enhancements to upgrade (Apps that upgrade themselves) #1163

denelon opened this issue Jun 14, 2021 · 6 comments · Fixed by #1795
Assignees
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Milestone

Comments

@denelon
Copy link
Contributor

denelon commented Jun 14, 2021

Description of the new feature/enhancement

Several packages manage upgrades themselves. One example is Visual Studio Code.

Proposed technical implementation details (optional)

Add a key to the manifest to identify packages with this capability.

Placeholder value: "PackageAutoUpgrades" (optional boolean key)

When the user executes winget upgrade this package would either not be displayed (as having an upgrade available), or it would be displayed in a manner that indicates this behavior.

When the user executes winget upgrade --all this package would not be upgraded.
To be in line with --include-unknown we should add --include-automatic.
We may also want to consider --force to apply all --include-<*> options.

Note: Schema changes have a large surface area: (Client, Validation Pipelines, Publishing Pipelines, REST API, Manifest Creator). This key may be added to the schema ahead of implementing the behavior in the client.

@denelon denelon added Issue-Feature This is a feature request for the Windows Package Manager client. Area-Manifest This may require a change to the manifest labels Jun 14, 2021
@ghost ghost added the Needs-Triage Issue need to be triaged label Jun 14, 2021
@denelon denelon removed the Needs-Triage Issue need to be triaged label Jun 14, 2021
@denelon denelon added this to the v.Next - Windows Package Manager milestone Jun 14, 2021
@Skgland
Copy link

Skgland commented Jun 15, 2021

Isn't this the same as #1137 but targeting a superset of packages as the other issue is only concerned with forced upgrades on launch where this is for all packages that will upgrade themselves, but not necessarily force an upgrade?

@denelon
Copy link
Contributor Author

denelon commented Jun 15, 2021

@Skgland, yes this is a "more generic" case so the publisher could essentially use this for a package that doesn't force an upgrade, but may support the option in their application.

@mddtest would you agree this covers the scenario in #1137 as well?

@mddtest
Copy link

mddtest commented Jun 15, 2021

I think it's best to only have it not show updates for ones that force update on launch.

If the app can be updated thought the program at any time it should still fit under the update --all parameter

Update on launch of program. Should be blocked.

Update with in program. Should still show up.

@denelon
Copy link
Contributor Author

denelon commented Jul 1, 2021

We're thinking about these, and we have looked a bit into the future regarding our plans to support package pinning #476. This would align with pinned packages don't automatically get upgraded with winget upgrade --all.

How about:

Installers:
  - InstallerType: exe
    InstallerArchitecture: x64
    InstallerSHA256: 12341234123412341234123412341234123412341234
    InstallerURL: https://www.contoso.com/awesomeapp/1.0.0/awesomeapp.x64.exe
    RequireExplicitUpgrade: true

@denelon
Copy link
Contributor Author

denelon commented Oct 1, 2021

"RequireExplicitUpgrade": {
"type": [ "boolean", "null" ],
"description": "Indicates whether the installer should be pinned by default from upgrade"
},

@denelon
Copy link
Contributor Author

denelon commented Oct 1, 2021

#1427

@denelon denelon modified the milestones: v1.3-Client, v1.4-Client May 31, 2022
Repository owner moved this from In Progress to Done in WinGet Aug 3, 2022
@ghost ghost added Resolution-Fix-Committed and removed In-PR Issue related to a PR labels Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants