Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support installers that always reboot by warning user / requiring an opt-in flag #2041

Open
JohnMcPMS opened this issue Mar 23, 2022 · 1 comment
Open

Support installers that always reboot by warning user / requiring an opt-in flag #2041

JohnMcPMS opened this issue Mar 23, 2022 · 1 comment
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Milestone
v.Next-Client

Comments

@JohnMcPMS
Copy link
Member

Description of the new feature / enhancement

Some installers will always reboot, regardless of what we ask of them. We can support these by having the data in the manifest to indicate it, then warning the user and possibly requiring an opt-in flag on the command line.

Proposed technical implementation details

Add a field to the manifest to indicate a forced reboot from installation.
Warn (aka error) the user if they try to install
Only proceed if a new option is passed in: --allow-reboot or similar
@JohnMcPMS JohnMcPMS added the Issue-Feature This is a feature request for the Windows Package Manager client. label Mar 23, 2022
@ghost ghost added the Needs-Triage Issue need to be triaged label Mar 23, 2022
@JohnMcPMS JohnMcPMS mentioned this issue Mar 23, 2022
Closed
5 tasks
@denelon denelon removed the Needs-Triage Issue need to be triaged label Mar 23, 2022
@denelon
Copy link
Contributor

denelon commented Mar 23, 2022

Could be similar to:

@denelon denelon added the Area-Manifest This may require a change to the manifest label Mar 23, 2022
@denelon denelon mentioned this issue Mar 23, 2022
Closed
@denelon denelon added this to the v1.4-Client milestone Apr 14, 2022
@ryfu-msft ryfu-msft mentioned this issue May 25, 2022
Closed
This was referenced Aug 11, 2022
Closed
Open
@denelon denelon modified the milestones: v1.4-Client, v.Next-Client Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Milestone
v.Next-Client
Development

No branches or pull requests
2 participants
@JohnMcPMS @denelon