Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An even better progress bar #2055

Closed
denelon opened this issue Mar 30, 2022 · 18 comments · Fixed by #2046
Closed

An even better progress bar #2055

denelon opened this issue Mar 30, 2022 · 18 comments · Fixed by #2046
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Milestone

Comments

@denelon
Copy link
Contributor

denelon commented Mar 30, 2022

Description of the new feature / enhancement

@chausner noticed the progress bar could be improved.

Proposed technical implementation details

This enhances the progress bar to use more fine-grained blocks, in steps of 1/8 of the width of a block, by leveraging the Block Element Unicode characters.

E.g. before:

image

After:

image

@denelon denelon added the Issue-Feature This is a feature request for the Windows Package Manager client. label Mar 30, 2022
@ghost ghost added the Needs-Triage Issue need to be triaged label Mar 30, 2022
@denelon denelon linked a pull request Mar 30, 2022 that will close this issue
2 tasks
@denelon denelon added this to the v1.3-Client milestone Mar 30, 2022
@denelon
Copy link
Contributor Author

denelon commented Mar 30, 2022

@JohnMcPMS thinks it's Smooooooooth...

smooth

@denelon denelon removed the Needs-Triage Issue need to be triaged label Mar 30, 2022
@denelon denelon closed this as completed Mar 30, 2022
@sba923
Copy link

sba923 commented Aug 18, 2022

What I currently get seems to use the "partial box" glyphs in the wrong order:

Administrator_ PowerShell - 7 2 6 2022-08-17 20-27-36

@denelon
Copy link
Contributor Author

denelon commented Aug 18, 2022

@chausner would you mind taking a look?

@chausner
Copy link
Contributor

@sba923 What font are you using in the terminal? If it's a custom font, can you please try switching to a default font temporarily and check whether the problem persists?

@sba923
Copy link

sba923 commented Aug 18, 2022

Of course, this had to be a font problem.

With Cascadia Code the behavior is correct.

With CaskaydiaCove NF (my default font needed by oh-my-posh), the behavior is not correct.

I'll check the glyphs used by the new progress bar in the two fonts, and will most likely report an issue for CaskaydiaCove NF.

@sba923
Copy link

sba923 commented Aug 18, 2022

Of course, this had to be a font problem.

With Cascadia Code the behavior is correct.

With CaskaydiaCove NF (my default font needed by oh-my-posh), the behavior is not correct.

I'll check the glyphs used by the new progress bar in the two fonts, and most likely will report an issue for CaskaydiaCove NF.

@sba923
Copy link

sba923 commented Aug 18, 2022

QED

With Cascadia Code:

image

With CaskaydiaCove NF:

image

@sba923
Copy link

sba923 commented Aug 18, 2022

The plot thickens: the required glyphs don't seem to exist in CaskaydiaCove NF:

image

image

@denelon
Copy link
Contributor Author

denelon commented Aug 18, 2022

Hopefully they are willing to add them. It would be really cool if you could winget upgrade CaskaydiaCove:

@sba923
Copy link

sba923 commented Aug 18, 2022

Opened ryanoasis/nerd-fonts#883

@sba923
Copy link

sba923 commented Aug 19, 2022

What I currently get seems to use the "partial box" glyphs in the wrong order:

Administrator_ PowerShell - 7 2 6 2022-08-17 20-27-36

Isn't this a good enough reason to make the new smooth progress bar a configurable opt-in setting?

@sba923
Copy link

sba923 commented Aug 19, 2022

Hopefully they are willing to add them.

It's coming: ryanoasis/nerd-fonts#883 (comment)

Tested OK with their latest build:

image

@denelon
Copy link
Contributor Author

denelon commented Aug 19, 2022

@sba923 thanks for finding the root cause and raising the issue at nerd-fonts!

@sba923
Copy link

sba923 commented Aug 19, 2022

@sba923 thanks for finding the root cause and raising the issue at nerd-fonts!

You're very welcome!

@sba923
Copy link

sba923 commented Aug 20, 2022

It would be really cool if you could winget upgrade CaskaydiaCove:

In the meantime, I'd like to know how to determine the versions of Cascadia Code and CaskadiaCove NF installed on my systems (from PowerShell, of course. What else? 😜)

@denelon
Copy link
Contributor Author

denelon commented Aug 22, 2022

In the meantime, I'd like to know how to determine the versions of Cascadia Code and CaskadiaCove NF installed on my systems (from PowerShell, of course. What else? 😜)

I'll ask around.

@KK-Designs
Copy link
Contributor

@JohnMcPMS thinks it's Smooooooooth...

smooth

Does the wingetdev include an option for testing the upgrade command? If so, where can I download that?

@SCIEN-00
Copy link

SCIEN-00 commented Aug 6, 2024

I would like something like this:
image
more information and cleaner imo 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants