Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElevationRequirement for specific InstallModes #2062

Open
OfficialEsco opened this issue Apr 1, 2022 · 3 comments
Open

ElevationRequirement for specific InstallModes #2062

OfficialEsco opened this issue Apr 1, 2022 · 3 comments
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Milestone

Comments

@OfficialEsco
Copy link

OfficialEsco commented Apr 1, 2022

Description of the new feature / enhancement

We've spotted a issue where Silent sometimes requires Administrator where SilentWithProgress does not, therefore we need a way to set the ElevationRequirement per InstallMode.

Affected Packages

Proposed technical implementation details

I don't know of a clean way of implementing it into the Schema

@OfficialEsco OfficialEsco added the Issue-Feature This is a feature request for the Windows Package Manager client. label Apr 1, 2022
@ghost ghost added the Needs-Triage Issue need to be triaged label Apr 1, 2022
@denelon denelon added Area-Manifest This may require a change to the manifest and removed Needs-Triage Issue need to be triaged labels Apr 1, 2022
@denelon denelon added this to the v1.4-Client milestone Apr 14, 2022
@Trenly
Copy link
Contributor

Trenly commented Apr 19, 2022

I don't know of a clean way of implementing it into the Schema

I've thought a little on this -

ElevationRequirement:
  Silent:  <>
  SilentWithProgress: <>
  Interactive: <>

To avoid this being a breaking change, the existing standard would have to be retained and just interpreted as if it applies to all the fields.

ElevationRequirement: <>

I figure these would do the trick -

"ElevationRequirementLevel": {
        "type": [
            "string",
            "null"
        ],
        "enum": [
            "elevationRequired",
            "elevationProhibited",
            "elevatesSelf"
        ],
        "description": "The installer's elevation requirement"
    }
"ElevationRequirement": {
        "oneOf": [
            {
                "$ref": "#/definitions/ElevationRequirementLevel"
            },
            {
                "type": [
                    "object",
                    "null"
                ],
                "properties": {
                    "Silent": {
                        "$ref": "#/definitions/ElevationRequirementLevel"
                    },
                    "SilentWithProgress": {
                        "$ref": "#/definitions/ElevationRequirementLevel"
                    },
                    "Interactive": {
                        "$ref": "#/definitions/ElevationRequirementLevel"
                    },
                }
            }
        ],
        "description": "The installer's elevation requirement"
    }

@solomoncyj
Copy link

How about making winget elevating when install,uninstall,upgrade commands are run

@OfficialEsco
Copy link
Author

How about making winget elevating when install,uninstall,upgrade commands are run

Why would they do that, that would break installers which prohibits elevation and winget would not work for users without administrator privileges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

No branches or pull requests

4 participants