Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependencies] - Manifest validation errors with msstore package identifier #3271

Open
Trenly opened this issue May 24, 2023 · 4 comments
Open
Labels
Area-Manifest This may require a change to the manifest Dependencies Blocked by microsoft/winget-cli/issues/163 Support for Dependencies msstore Issue related to "msstore" REST source

Comments

@Trenly
Copy link
Contributor

Trenly commented May 24, 2023

Brief description of your issue

Some packages may depend on programs from the Microsoft Store like Xbox Game Bar. Adding these packages as dependencies throws a manifest validation error. Ignoring the validation error, the dependencies install correctly

Steps to reproduce

Dependencies:
  PackageDependencies:
    - PackageIdentifier: 9NZKPSTSNW4P

Expected behavior

Manifest validation to succeed

Actual behavior

Manifest Error: Schema Error. [Schema validation failed.
Error context: <root>[Dependencies][PackageDependencies][0][PackageIdentifier] Description: Failed to match regex specified by 'pattern' constraint.
Error context: <root>[Dependencies][PackageDependencies][0] Description: Failed to validate against schema associated with property name 'PackageIdentifier'.
Error context: <root>[Dependencies][PackageDependencies] Description: Failed to validate item #0 in array.
Error context: <root>[Dependencies] Description: Failed to validate against schema associated with property name 'PackageDependencies'.
Error context: <root> Description: Failed to validate against schema associated with property name 'Dependencies'.
]

Environment

PS D:\Git\winget-pkgs> winget --info
Windows Package Manager (Preview) v1.5.1361-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19044.2965
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.20.1361.0

Winget Directories
-------------------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Enabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Enabled
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue need to be triaged label May 24, 2023
@stephengillie stephengillie added msstore Issue related to "msstore" REST source and removed Needs-Triage Issue need to be triaged labels May 25, 2023
@Trenly
Copy link
Contributor Author

Trenly commented May 25, 2023

@stephengillie - can I also request Dependencies and Area-Manifest labels?

@stephengillie stephengillie added Area-Manifest This may require a change to the manifest Dependencies Blocked by microsoft/winget-cli/issues/163 Support for Dependencies labels May 26, 2023
@denelon
Copy link
Contributor

denelon commented Jun 5, 2023

We haven't really been considering "cross-source" dependencies. That's an area of complexity and security concerns. For now, we treat them as "same source only".

@OfficialEsco
Copy link

I got an interesting Cross-source issue then microsoft/winget-pkgs#132856
Lenovo Vantage Service is a piece of silly software that you HAVE to install AFTER installing Lenovo Vantage, which is only available in the store...
This creates a issue in InTune where your users are not Administrator as it requires Administrator to install this. (You could obv add a dependency to this in InTune but nevermind that)

Isn't the store repo a verified trusted source?

@Trenly
Copy link
Contributor Author

Trenly commented Jan 5, 2024

I got an interesting Cross-source issue then microsoft/winget-pkgs#132856 Lenovo Vantage Service is a piece of silly software that you HAVE to install AFTER installing Lenovo Vantage, which is only available in the store... This creates a issue in InTune where your users are not Administrator as it requires Administrator to install this. (You could obv add a dependency to this in InTune but nevermind that)

Isn't the store repo a verified trusted source?

I think the main issue with Cross-Source dependencies is that they would fail if the user has removed the source. For example, I usually remove the msstore source on my dev machine since I don't need it, and when I query for packages it's usually to see whether or not they already exist in the repo and I don't like having to specify -s winget on every command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Manifest This may require a change to the manifest Dependencies Blocked by microsoft/winget-cli/issues/163 Support for Dependencies msstore Issue related to "msstore" REST source
Projects
None yet
Development

No branches or pull requests

4 participants