Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell Checking workflow runs fail for no apparent reason #133051

Closed
marco-eckstein opened this issue Jan 7, 2024 Discussed in #87054 · 9 comments
Closed

Spell Checking workflow runs fail for no apparent reason #133051

marco-eckstein opened this issue Jan 7, 2024 Discussed in #87054 · 9 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@marco-eckstein
Copy link
Contributor

marco-eckstein commented Jan 7, 2024

Discussed in #87054

Originally posted by clovett November 1, 2022
I'm submitting this PR: https://github.com/microsoft/winget-pkgs/pull/87051/checks

But I get runs like this reporting spellcheck failures to me:
https://github.com/clovett/winget-pkgs/actions/runs/3366593799

It's reporting spelling errors in packages that have nothing to do with me or my PR?

image

I have the same issue. Every time I push master or another branch, I get the notification Spell Checking workflow run failed for.... Until a few days ago, I did not have this issue even with an up-to-date fork. Only after I synced my fork again, it appeared.

Pull requests for the failing branches have been accepted anyway, so apparently the issue can be ignored. But Microsoft, please fix it!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jan 7, 2024
@stephengillie stephengillie added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Jan 8, 2024
@Trenly
Copy link
Contributor

Trenly commented Jan 10, 2024

@jsoref - can you help us out here?

@twpayne
Copy link
Contributor

twpayne commented Jan 10, 2024

I've hit this problem too, which is preventing me from updating my software in winget-pkgs: twpayne#434 (comment)

The spell check seems to apply to the whole repo, which includes files outside the PR, i.e. any spelling error breaks winget-pkgs for everyone.

I would suggest disabling the check-spelling workflow immediately until this is fixed.

@Trenly
Copy link
Contributor

Trenly commented Jan 10, 2024

I would suggest disabling the check-spelling workflow immediately until this is fixed.

You will need to disable the workflow on your fork, since each fork of the repo runs the workflows independently

@twpayne
Copy link
Contributor

twpayne commented Jan 10, 2024

I've disabled GitHub Actions on my fork now.

@jsoref
Copy link
Contributor

jsoref commented Jan 10, 2024

I can't see this file in https://github.com/microsoft/winget-pkgs/tree/master/.github nor in https://github.com/clovett/winget-pkgs/tree/master/.github

If someone can point me to it live somewhere, I can provide better advice in a bit (I'm hopping offline shortly, I should be back and it should be simple if I can see the file; normally I'd use a computer and hunt for the file myself, but I only have a phone atm and really need to hop off).

@Trenly
Copy link
Contributor

Trenly commented Jan 10, 2024

I can't see this file in master/.github nor in clovett/winget-pkgs@master/.github

If someone can point me to it live somewhere, I can provide better advice in a bit (I'm hopping offline shortly, I should be back and it should be simple if I can see the file; normally I'd use a computer and hunt for the file myself, but I only have a phone atm and really need to hop off).

I believe that specific file has been removed from master for a while, so perhaps that fork is just out of date.

@jsoref
Copy link
Contributor

jsoref commented Jan 10, 2024

That seems like the most likely explanation.

@Trenly
Copy link
Contributor

Trenly commented Jan 20, 2024

Close with reason: Fixed spelling and PR has been merged to master;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

6 participants