-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that version number in "Add/Remove programs" matches manifest version during manifest validation #13620
Comments
I also suggest that winget validater should use winget update to test submitted installers with older versions (like vs code), then use winget uninstall to test if it can be uninstalled normally. |
Is there any chance that the test cases are opened up at some point, at the very least so we can run them locally? The community could write some of this code, especially for the smaller stuff (product code bug, for instance). |
@jedieaston we do want to open validation up. We have a bunch of infrastructure work to do this. We've been discussing some different architectural approaches to make this possible. We got a lot of mileage out of Azure DevOps, but we're starting to see some other approaches that might scale better, and give the community more surface area to help. I can't express in text "here" how much we all appreciate the support and constructive feedback! |
@denelon Looks like this one was missed with Area-Validation-Pipelines |
Description of the new feature/enhancement
As reported here, the
winget upgrade
command may incorrectly detect updates to be available even when the latest version is installed in case the version number in Add/Remove programs does not match the version in the manifest.I suggest that the manifest validator checks for this condition automatically after program installation and either fails the validation process (requiring the manifest submitter to adapt the manifest version) or creates a warning so that the submitter can take action if they want.
This suggestion is closely related to #13622.
The text was updated successfully, but these errors were encountered: