Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version number and installer type issuefor 7zip.7zipalpha #17484

Closed
lychichem opened this issue Jun 14, 2021 · 6 comments
Closed

Version number and installer type issuefor 7zip.7zipalpha #17484

lychichem opened this issue Jun 14, 2021 · 6 comments
Labels
Help-Wanted This is a good candidate work item from the community.
Milestone

Comments

@lychichem
Copy link
Contributor

lychichem commented Jun 14, 2021

@itzlevvie2 If you want to use .msi installers, then .exe type will be useless, as we cannot select installer type now. And if you want to use .exe, you need to remove .msi installer. And,the two type installers seems give different version numbers in ARP. At least .exe installer will show 21.02 alpha, but not 21.02.0.0.
image

@ghost ghost added the Needs: Triage label Jun 14, 2021
@OfficialEsco
Copy link
Contributor

Tag @ItzLevvie 😁
Ok so i did notice this, we might have to split them into 7zip.7zip.Alpha.msi/exe if its in a upgrade loop (That should work)
The reason the MSI is at the top is because people over at winget-cli would prefer only MSI's, however msi and exe can be in the same manifest for winget upgrade purposes

@ghost
Copy link

ghost commented Jun 14, 2021

I made PRs for it: #17503 and #17502.

@OfficialEsco
Copy link
Contributor

OfficialEsco commented Jun 14, 2021

Hmm

PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> winget list
Name                    Id                                           Version           Available   Source
---------------------------------------------------------------------------------------------------------
7-Zip 21.02 alpha (x64) 7-Zip                                        21.02 alpha
7-Zip Alpha             7zip.7zip.Alpha.msi

image

I think the - might be needed

@denelon
Copy link
Contributor

denelon commented Jun 14, 2021

@denelon denelon added Help-Wanted This is a good candidate work item from the community. and removed Needs: Triage labels Jun 14, 2021
@lychichem
Copy link
Contributor Author

Seems fixed. Thank you @itzlevvie2

@OfficialEsco
Copy link
Contributor

Just did a few tests, now stable 7-Zip 19.00 installed via normal exe shows up as 7-Zip Alpha (exe) and a update to 7-Zip Alpha 21.02 alpha

Name                  Id                                           Version          Available   Source
------------------------------------------------------------------------------------------------------
7-Zip Alpha (exe)     7zip.7zip.Alpha.exe                          19.00            21.02 alpha winget
7-Zip                 7zip.7zip                                    19.00.00.0

We miiiight have to wait for Channel support?

@denelon denelon added this to the 1.7 Packages milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help-Wanted This is a good candidate work item from the community.
Projects
None yet
Development

No branches or pull requests

3 participants