Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: RedHat.VirtIO version 0.1.262-2 #177861

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

New package: RedHat.VirtIO version 0.1.262-2 #177861

wants to merge 2 commits into from
+40 −0

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Oct 4, 2024 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the URL-Validation-Error Microsoft Defender SmartScreen triggered during automatic validation label Oct 4, 2024
@wingetbot
Copy link
Collaborator

Url validation error

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Oct 4, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. URL-Validation-Error Microsoft Defender SmartScreen triggered during automatic validation labels Oct 4, 2024
@wingetbot wingetbot added the URL-Validation-Error Microsoft Defender SmartScreen triggered during automatic validation label Oct 4, 2024
@wingetbot
Copy link
Collaborator

Url validation error

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Oct 4, 2024
@Dragon1573
New package: RedHat.VirtIO version 0.1.262-2
cbbf720 
Signed-off-by: Dragon1573 <49941141+Dragon1573@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. URL-Validation-Error Microsoft Defender SmartScreen triggered during automatic validation labels Oct 4, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Oct 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Oct 4, 2024
@stephengillie
Copy link
Collaborator

Hi @Dragon1573,

Could you add a PackageUrl?

@stephengillie
Copy link
Collaborator

Verify:
image

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Oct 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Oct 5, 2024
@Dragon1573
Apply suggestions from code review
e8fcff4 
- Add `PackageUrl` to the manifest.
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Domain New-Package labels Oct 5, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Oct 5, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hello @Dragon1573,

One or more of the installer URLs doesn't appear valid.

This may happen for sites with policies prohibiting distribution or use by third parties.

This may happen for URLs pointing to domains that do not align with the publisher domain or package domain. If you could provide supporting evidence from the publisher that the URLs for the installer are correct, that would help us to validate and approve this PR.

Template: msftbot/validationError/urls/domain

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Oct 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzLevvie ItzLevvie ItzLevvie approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@Dragon1573 Dragon1573

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Author-Feedback This needs a response from the author. New-Package Validation-Domain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request]: virtio-win
4 participants
@Dragon1573 @wingetbot @stephengillie @ItzLevvie