Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: GaijinNetwork.StarConflict version 1.0.3.10 #218010

Merged
merged 3 commits into from
Feb 6, 2025
Merged

New version: GaijinNetwork.StarConflict version 1.0.3.10 #218010

merged 3 commits into from
Feb 6, 2025

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Jan 28, 2025 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@Dragon1573
New version: GaijinNetwork.StarConflict version 1.0.3.10
305d763 
Signed-off-by: Dragon1573 <49941141+Dragon1573@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

2 similar comments
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot
Copy link
Collaborator

=== manifests\g\GaijinNetwork\StarConflict\1.0.3.10 ===
Missing Properties value based on version 1.0.3.66:
MinimumOSVersion

@wingetbot wingetbot added Manifest-Metadata-Consistency New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 28, 2025
@Dragon1573 @DuckDuckStudio
Apply suggestions from code review
9e5de6b 
- Remove "Product Code" property, since it's not configured in ISS file.

Co-authored-by: 鸭鸭「カモ」 <Yzcbs123@163.com>
auto-merge was automatically disabled January 29, 2025 06:03

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed Manifest-Metadata-Consistency New-Manifest labels Jan 29, 2025
@wingetbot
Copy link
Collaborator

=== manifests\g\GaijinNetwork\StarConflict\1.0.3.10 ===
Missing Properties value based on version 1.0.3.66:
MinimumOSVersion

@wingetbot wingetbot added Manifest-Metadata-Consistency New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 29, 2025
@stephengillie
Copy link
Collaborator

=== manifests\g\GaijinNetwork\StarConflict\1.0.3.10 === Missing Properties value based on version 1.0.3.66: MinimumOSVersion

Hi @Dragon1573,

Is the MinimumOSVersion removal significant?

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Feb 3, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Feb 5, 2025
auto-merge was automatically disabled February 5, 2025 14:32

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Completed Validation passed Manifest-Metadata-Consistency New-Manifest labels Feb 5, 2025
@wingetbot wingetbot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Feb 5, 2025
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 5, 2025
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Feb 5, 2025
@stephengillie
Copy link
Collaborator

stephengillie commented Feb 5, 2025 •
edited
Loading

Verify:
image
image

Edit:
Hi @Dragon1573,

It appears that the installer writes a slightly different version number to the Registry than the application displays. Is this expected?

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Feb 5, 2025
auto-merge was automatically disabled February 5, 2025 18:00

Pull Request is not mergeable

@DuckDuckStudio
Copy link
Contributor

Maybe it's a version difference between the game and the launcher?
If so, should the package identifier be changed to GaijinNetwork.StarConflictLauncher (This was the first identifier of the package, and was changed to the current identifier in #55914 .)?

@Dragon1573
Copy link
Contributor Author

I think it's expected. The InstallerUrl names this file as starconf_launcher_1.0.3.10.exe. It should be an install wizard of the game launcher instead of the main game itself.

@stephengillie - As your screenshot, the main game itself is around 9.1GiB and should be downloaded by the launcher externally.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Feb 6, 2025
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Feb 6, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Feb 6, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 58d9048 into microsoft:master Feb 6, 2025
2 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Dragon1573 Dragon1573 deleted the issues/217877 branch February 7, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DuckDuckStudio DuckDuckStudio DuckDuckStudio left review comments

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service[bot] approved these changes

@stephengillie stephengillie stephengillie approved these changes

Assignees

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update Request]: GaijinNetwork.StarConflict version 1.0.3.x
4 participants
@Dragon1573 @wingetbot @stephengillie @DuckDuckStudio