Skip to content
This repository has been archived by the owner on Feb 20, 2021. It is now read-only.

[BUG] Sliding layer does not fully disappear when layer is in small width or height #37

Open
gebing opened this issue Aug 13, 2013 · 1 comment

Comments

@gebing
Copy link

gebing commented Aug 13, 2013

Sliding layer does not fully disappear when calling closeLayer(true). This will occur when sliding layer's layout is in small width or height.

I checked the code, and found it is caused by computeScroll() has not been called again when mScroller is reaching to its final position but not the final position.

Eg. i have a sliding layer with height 200, when i closed the sliding layer, and it will call smoothScrollTo(0, 200), and computeScroll() will stop to be called when mScroller's current position reach to 198. So the layer will not scroll to the position 220, and will not totally disappear.

Further, i will make a pull request to fix this bug.

@gebing
Copy link
Author

gebing commented Aug 13, 2013

I make a pull request #38 to fix this bug.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant