Powershell components many errors

[csando]

Describe the bug
Required Powershell scripts for provisioning the Azure AD app, whether in PS 5.1 or 7.x, present multiple errors are don't work

To Reproduce
Steps to reproduce the behavior:
Run any of the included powershell scripts, resist rising urge to kill

Expected behavior
Scripts to have been tested and to work as described

Additional context
Errors encountered, there are probably more but I gave up on the provided scripts and made everything manually

• reliance on old versions of PS modules it uses
• Issues with ps 7.x; has to reinstall AZ module 5.5.0 every single time you run it; fails running in 7.x because of "Could not load type 'System.Security.Cryptography.SHA256Cng'" error.
• fails creating the application because the identifier URI is invalid (new-guid doesn't work for this. Creating the app manually first allows the script to proceed... but then)
• fails creating the application because the replyURLs are invalid
• line 207 in Set-GraphCredentialsAzureADApplication.ps1 straight up missing a variable name ($ = convertto-securestrin...) Should be $graphtenantsecret
• entire script and PS modules used need to be updated, old modules no longer work properly.
  Error: New-AzADServicePrincipal: Values of identifierUris property must use a verified domain of the organization or its subdomain Azure/azure-powershell#16097
  https://docs.microsoft.com/en-us/azure/active-directory/develop/reference-breaking-changes#appid-uri-in-single-tenant-applications-will-require-use-of-default-scheme-or-verified-domains
• needs to keep installing modules that already exist on the computer, even ones it has just installed, which randomly and often fails with "PackageManagement\Install-Package : Access to the cloud file is denied".
• Due to the above error, to workaround that you just have to run the script multiple times even if you have gone through and ironed out all the other errors
• set-serviceprincipal.ps1, also affected by breaking changes above
• set-serviceprincipal.ps1, New-AzRoleAssignment : Cannot find role definition with name 'CSEO DevOps Role'. Because this is a custom role

[pauldalyii-msft]

@csando, thanks for your candid feedback.

We have made a number of updates to our documentation - but there's still much room for improvement regarding the setup process. ex:

• we are in the process of publishing a second repo that more clearly illustrates how to setup gmm using a git submodule reference to this one
• we are considering the use of docker containers to help ensure the correct versions of powershell and powershell modules are present so that the scripts "just run".

We'll keep this issue open for the time being and circle back once we have more progress to share.