-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imports in PHP and Python snippets don't respect the ApiVersion to import from correct package. #2050
Comments
Concern on this, snippets are served to customer via GE and docs, if we include the APIVersion, will this be confusing for users.
|
Based on the API version selected in GE or docs, we should match the same. Both versions of the API should be able to live side by side in the same project. So my call would be to support the API version in the namespaces. We have it for other languages too... |
Hi @shemogumbe
NOTE: I also answered to this in your comment to the PR. |
Perftect, thanks for the clarification @SilasKenneth @sebastienlevert |
Describe the bug
When generating the beta api snippets, this
PHP
snippetshould be
And this
Python
snippetshould be
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: