Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Share button to move next to query #1413

Closed
Tracked by #1416
RabebOthmani opened this issue Feb 3, 2022 · 2 comments · Fixed by #1459
Closed
Tracked by #1416

[UI] Share button to move next to query #1413

RabebOthmani opened this issue Feb 3, 2022 · 2 comments · Fixed by #1459
Assignees
Labels
type:enhancement Enhancement request targeting an existing experience type:user-experience An issue related to user experience mainly ui/ux

Comments

@RabebOthmani
Copy link

RabebOthmani commented Feb 3, 2022

As a user, I want the ability to copy my query url
so that I can easily add it to my apps or use it with other tooling

Acceptance Criteria

  • Remove the Share button and replace it with copy icon (similar to what's on the snippets tab)
  • Add copy icon next to the query box
  • Copy button should behave in same way as copy code snippet
  • Both copy and doc icons should move outside the URL box.

Expected UI

copy url

This is an illustration of the desired outcome but not a final design.

@RabebOthmani RabebOthmani added UI Polish type:user-experience An issue related to user experience mainly ui/ux type:enhancement Enhancement request targeting an existing experience labels Feb 3, 2022
@ghost ghost added the ToTriage label Feb 3, 2022
@RabebOthmani RabebOthmani added this to the Feb 04 - Mar 03 milestone Feb 4, 2022
@ghost ghost removed the ToTriage label Feb 4, 2022
@Onokaev Onokaev self-assigned this Feb 9, 2022
@RabebOthmani
Copy link
Author

@Onokaev apologies for not following with this properly. How did we end up with a result way different from the initial requirement? Can you explain to me again why this button is on the right? And why it is so big? The idea was to have something similar to the info icon, small and crisp.

@Onokaev
Copy link
Contributor

Onokaev commented Mar 4, 2022

@RabebOthmani it's okay.
We discussed it with you during the sprint check-in. We engaged the UX team and presented their suggestion during our mid-sprint check-in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement request targeting an existing experience type:user-experience An issue related to user experience mainly ui/ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants