Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing expanded view with [x] stays in "Expand" tab #1827

Closed
zengin opened this issue Jun 11, 2022 · 1 comment · Fixed by #1850
Closed

Closing expanded view with [x] stays in "Expand" tab #1827

zengin opened this issue Jun 11, 2022 · 1 comment · Fixed by #1850
Assignees
Labels
type:bug Something isn't working
Milestone

Comments

@zengin
Copy link

zengin commented Jun 11, 2022

Describe the bug
Dismissing expanded view does not retain tab selection.

To Reproduce

  • Go to Graph Explorer
  • Run a query that has a response body (GET /me should work in sandbox)
  • Click on "Expand"
  • Dismiss the expanded view by clicking on [x]
  • Response pane stays with a focus on Expand "tab" without any content being shown as if there is no response.

Expected behavior
I think whichever tab is chosen in the expanded view should stay selected when the expanded view is dismissed.

A nice-to-have would be to always remember the selected tab, e.g. expanding "code snippets" tab defaults into "response preview" being selected in the expanded view.

Screenshots
Before expansion:
image

Expanded view:
image

After expanded view is dismissed:
image

@ghost ghost added the ToTriage label Jun 11, 2022
@Onokaev Onokaev added this to the June-2022 milestone Jun 13, 2022
@ghost ghost removed the ToTriage label Jun 13, 2022
@adhiambovivian adhiambovivian added the type:bug Something isn't working label Jun 13, 2022
@zengin
Copy link
Author

zengin commented Jun 23, 2022

Thanks for quick turnaround on this @Onokaev! Really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants