Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct cachekey in files #3257

Merged
merged 2 commits into from
Jul 18, 2024
Merged

fix: correct cachekey in files #3257

merged 2 commits into from
Jul 18, 2024

Conversation

russgove
Copy link
Contributor

Closes #3248

PR Type

Bugfix

Description of the changes

use the same cachekey when storing and retrieving file lists from cache

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@russgove russgove requested a review from a team as a code owner July 16, 2024 13:29
Copy link
Contributor

Thank you for creating a Pull Request @russgove.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

musale
musale previously approved these changes Jul 17, 2024
@musale
Copy link
Contributor

musale commented Jul 17, 2024

@russgove run yarn run prettier:write to fix some of the prettier warnings.

@musale musale merged commit 5551351 into microsoftgraph:main Jul 18, 2024
9 of 10 checks passed
@Mnickii Mnickii changed the title fix cachekey in files fix: correct cachekey in files Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Cache does not seem to be working on FileList component
2 participants