Skip to content
This repository has been archived by the owner on Nov 21, 2023. It is now read-only.

TB 78 support #94

Open
hopalongrock opened this issue Sep 10, 2020 · 26 comments
Open

TB 78 support #94

hopalongrock opened this issue Sep 10, 2020 · 26 comments
Assignees

Comments

@hopalongrock
Copy link

I used CW on version 52, 60 and now on 68.
Is it possible to rewrite it to version 78?

Thanks

@cleidigh
Copy link
Collaborator

@hopalongrock
I will be doing the update , but I need to do work on a couple other extensions first.

@jh20001
Copy link

jh20001 commented Sep 25, 2020

That's fantastic news. Looking forward to the update myself :)

@BillH99999
Copy link

@cleidigh

Christopher, just wondered if there was any guess on when you might be able to get around to this extension? No hurry or anything, just wondering.

Thanks!
Bill

@cleidigh
Copy link
Collaborator

cleidigh commented Nov 25, 2020

@micz
@hopalongrock
@jh20001
@BillH99999
@talagrand
@SergeLalonde
@fenjen
@sengaya
@zertrin
@binarykitchen

All

I got a little time on this.
track and find the beta in #95
v8 b3 is fairly functional
any testing help 'will make things go faster!
Thanks
Christopher

@BillH99999
Copy link

Looks good. I don't use any of the more advanced functionality, but I was able to save my CW defaults, modify my defaults, restore my defaults, and create a new folder which used the defaults all without any problems.

Thanks so much for working on the plugin and converting it to work with TB 78.

Bill

@cleidigh cleidigh self-assigned this Nov 25, 2020
@cleidigh
Copy link
Collaborator

@BillH99999
excellent!!
Good beta feedback before I even finish my notification!
thanks for the quick response
doing my best to appreciate the comments!
Christopher

@hopalongrock
Copy link
Author

I use only Save Columns as / Reset Columns to CW default, and they work fine.

Thanks

Laszlo

@Ircama
Copy link

Ircama commented Nov 26, 2020

any testing help 'will make things go faster!

Thanks a lot, it works!
I have just noticed that the "CC" column size is always reset after restarting Thunderbird, even if I use "Save Columns as default CW" before closing the app and after resizing the column (not sure that this is wanted, or it depends on this plugin, or it is standard behavior).

@cleidigh
Copy link
Collaborator

@Ircama
thanks for the feedback! that's a weird one , the extension actually does not touch the column widths so the core must be doing something. I will try to reproduce.
cheers
Christopher

@BillH99999
Copy link

BillH99999 commented Nov 27, 2020

@cleidigh
I don't know what is going on, but now I'm having some problems. I added the column Order Received by checking the box and now I can't get rid of it or any other previously selected column. When I try to de-select a column, it changes the up/down arrows on the right to empty squares.

And when I try to add a new folder, the columns are not what is selected in the options. It is not displaying all the columns that have now got the empty squares, but is only adding the Read column (which coincidently also has the empty squares).

image1

image2

@cleidigh
Copy link
Collaborator

@BillH99999
I'm not surprised because of all the tricks I have to do
I will try and reproduce
any output in the Console?
C

@BillH99999
Copy link

@cleidigh
I don't know if any of this is of any use, but these occurred while I was experiencing the problem.

16:25:39.576
[Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]" nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)" location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 658" data: no] L10nRegistry.jsm:658:19
16:25:39.763
Error while loading 'jar:file:///C:/Program%20Files/Mozilla%20Thunderbird/omni.ja!/chrome/messenger/search-extensions/twitter/manifest.json' (NS_ERROR_FILE_NOT_FOUND) Extension.jsm:570
16:25:39.875
[Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]" nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)" location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 658" data: no] L10nRegistry.jsm:658:19
16:25:40.246
[Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]" nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)" location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 658" data: no] L10nRegistry.jsm:658:19
16:25:40.521
[Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]" nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)" location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 658" data: no] L10nRegistry.jsm:658:19
16:25:40.522
[Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]" nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)" location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 658" data: no] L10nRegistry.jsm:658:19
16:25:40.977
DOMException: CSSStyleSheet.cssRules getter: Can't access rules of still-loading stylsheet tabmail.js:914:21
16:30:53.242
TypeError: domNode is null
reflectFiltererState chrome://messenger/content/quickFilterBar.js:289
onTabSwitched chrome://messenger/content/quickFilterBar.js:509
updateCurrentTab chrome://messenger/content/tabmail.js:1759
connectedCallback chrome://messenger/content/tabmail-tabs.js:660
set selectedIndex chrome://messenger/content/tabmail-tabs.js:724
set selectedItem chrome://global/content/elements/tabbox.js:565
_selectNewTab chrome://global/content/elements/tabbox.js:735
on_mousedown chrome://global/content/elements/tabbox.js:331
handleEvent chrome://global/content/customElements.js:466
tabmail.js:1761:21
updateCurrentTab chrome://messenger/content/tabmail.js:1761
connectedCallback chrome://messenger/content/tabmail-tabs.js:660
set selectedIndex chrome://messenger/content/tabmail-tabs.js:724
set selectedItem chrome://global/content/elements/tabbox.js:565
_selectNewTab chrome://global/content/elements/tabbox.js:735
on_mousedown chrome://global/content/elements/tabbox.js:331
handleEvent chrome://global/content/customElements.js:466
16:31:05.868
onLoadingFolder event listener FAILED; TypeError: domNode is null at: reflectFiltererState@chrome://messenger/content/quickFilterBar.js:289:29
onLoadingFolder@chrome://messenger/content/quickFilterBar.js:139:12
_fireListeners@chrome://messenger/content/folderDisplay.js:74:32
onLoadingFolder@chrome://messenger/content/folderDisplay.js:1066:34
_prepareToLoadView@resource:///modules/DBViewWrapper.jsm:1048:19
open@resource:///modules/DBViewWrapper.jsm:805:12
show@chrome://messenger/content/folderDisplay.js:823:19
FolderPaneSelectionChange@chrome://messenger/content/commandglue.js:350:18
onselect@chrome://messenger/content/messenger.xhtml:1:1
MozTreeChildren/<@chrome://global/content/elements/tree.js:69:28
folderDisplay.js:76
16:31:15.495
NS_ERROR_NOT_AVAILABLE: ActivityManager.jsm:127
16:33:54.589
TypeError: domNode is null
reflectFiltererState chrome://messenger/content/quickFilterBar.js:289
onTabSwitched chrome://messenger/content/quickFilterBar.js:509
updateCurrentTab chrome://messenger/content/tabmail.js:1759
connectedCallback chrome://messenger/content/tabmail-tabs.js:660
set selectedIndex chrome://messenger/content/tabmail-tabs.js:724
set selectedItem chrome://global/content/elements/tabbox.js:565
_selectNewTab chrome://global/content/elements/tabbox.js:735
on_mousedown chrome://global/content/elements/tabbox.js:331
handleEvent chrome://global/content/customElements.js:466
tabmail.js:1761:21
16:35:09.104
onLoadingFolder event listener FAILED; TypeError: domNode is null at: reflectFiltererState@chrome://messenger/content/quickFilterBar.js:289:29
onLoadingFolder@chrome://messenger/content/quickFilterBar.js:139:12
_fireListeners@chrome://messenger/content/folderDisplay.js:74:32
onLoadingFolder@chrome://messenger/content/folderDisplay.js:1066:34
_prepareToLoadView@resource:///modules/DBViewWrapper.jsm:1048:19
open@resource:///modules/DBViewWrapper.jsm:805:12
show@chrome://messenger/content/folderDisplay.js:823:19
FolderPaneSelectionChange@chrome://messenger/content/commandglue.js:350:18
onselect@chrome://messenger/content/messenger.xhtml:1:1
MozTreeChildren/<@chrome://global/content/elements/tree.js:69:28
folderDisplay.js:76
16:35:14.041
onLoadingFolder event listener FAILED; TypeError: domNode is null at: reflectFiltererState@chrome://messenger/content/quickFilterBar.js:289:29
onLoadingFolder@chrome://messenger/content/quickFilterBar.js:139:12
_fireListeners@chrome://messenger/content/folderDisplay.js:74:32
onLoadingFolder@chrome://messenger/content/folderDisplay.js:1066:34
_prepareToLoadView@resource:///modules/DBViewWrapper.jsm:1048:19
open@resource:///modules/DBViewWrapper.jsm:805:12
_forceOpen@resource:///modules/DBViewWrapper.jsm:1332:10
_renameCompleted@resource:///modules/DBViewWrapper.jsm:1337:12
_notifyHelper@resource:///modules/DBViewWrapper.jsm:196:30
OnItemEvent@resource:///modules/DBViewWrapper.jsm:242:12
folderDisplay.js:76
16:35:15.979
onLoadingFolder event listener FAILED; TypeError: domNode is null at: reflectFiltererState@chrome://messenger/content/quickFilterBar.js:289:29
onLoadingFolder@chrome://messenger/content/quickFilterBar.js:139:12
_fireListeners@chrome://messenger/content/folderDisplay.js:74:32
onLoadingFolder@chrome://messenger/content/folderDisplay.js:1066:34
_prepareToLoadView@resource:///modules/DBViewWrapper.jsm:1048:19
open@resource:///modules/DBViewWrapper.jsm:805:12
show@chrome://messenger/content/folderDisplay.js:823:19
FolderPaneSelectionChange@chrome://messenger/content/commandglue.js:350:18
onselect@chrome://messenger/content/messenger.xhtml:1:1
MozTreeChildren/<@chrome://global/content/elements/tree.js:69:28
folderDisplay.js:76
16:35:18.623
onLoadingFolder event listener FAILED; TypeError: domNode is null at: reflectFiltererState@chrome://messenger/content/quickFilterBar.js:289:29
onLoadingFolder@chrome://messenger/content/quickFilterBar.js:139:12
_fireListeners@chrome://messenger/content/folderDisplay.js:74:32
onLoadingFolder@chrome://messenger/content/folderDisplay.js:1066:34
_prepareToLoadView@resource:///modules/DBViewWrapper.jsm:1048:19
open@resource:///modules/DBViewWrapper.jsm:805:12
_forceOpen@resource:///modules/DBViewWrapper.jsm:1332:10
_renameCompleted@resource:///modules/DBViewWrapper.jsm:1337:12
_notifyHelper@resource:///modules/DBViewWrapper.jsm:196:30
OnItemEvent@resource:///modules/DBViewWrapper.jsm:242:12
folderDisplay.js:76
16:35:19.401
onLoadingFolder event listener FAILED; TypeError: domNode is null at: reflectFiltererState@chrome://messenger/content/quickFilterBar.js:289:29
onLoadingFolder@chrome://messenger/content/quickFilterBar.js:139:12
_fireListeners@chrome://messenger/content/folderDisplay.js:74:32
onLoadingFolder@chrome://messenger/content/folderDisplay.js:1066:34
_prepareToLoadView@resource:///modules/DBViewWrapper.jsm:1048:19
open@resource:///modules/DBViewWrapper.jsm:805:12
show@chrome://messenger/content/folderDisplay.js:823:19
FolderPaneSelectionChange@chrome://messenger/content/commandglue.js:350:18
onselect@chrome://messenger/content/messenger.xhtml:1:1
MozTreeChildren/<@chrome://global/content/elements/tree.js:69:28
folderDisplay.js:76
16:35:22.216
onLoadingFolder event listener FAILED; TypeError: domNode is null at: reflectFiltererState@chrome://messenger/content/quickFilterBar.js:289:29
onLoadingFolder@chrome://messenger/content/quickFilterBar.js:139:12
_fireListeners@chrome://messenger/content/folderDisplay.js:74:32
onLoadingFolder@chrome://messenger/content/folderDisplay.js:1066:34
_prepareToLoadView@resource:///modules/DBViewWrapper.jsm:1048:19
open@resource:///modules/DBViewWrapper.jsm:805:12
_forceOpen@resource:///modules/DBViewWrapper.jsm:1332:10
_renameCompleted@resource:///modules/DBViewWrapper.jsm:1337:12
_notifyHelper@resource:///modules/DBViewWrapper.jsm:196:30
OnItemEvent@resource:///modules/DBViewWrapper.jsm:242:12
folderDisplay.js:76
16:35:23.533
onLoadingFolder event listener FAILED; TypeError: domNode is null at: reflectFiltererState@chrome://messenger/content/quickFilterBar.js:289:29
onLoadingFolder@chrome://messenger/content/quickFilterBar.js:139:12
_fireListeners@chrome://messenger/content/folderDisplay.js:74:32
onLoadingFolder@chrome://messenger/content/folderDisplay.js:1066:34
_prepareToLoadView@resource:///modules/DBViewWrapper.jsm:1048:19
open@resource:///modules/DBViewWrapper.jsm:805:12
show@chrome://messenger/content/folderDisplay.js:823:19
FolderPaneSelectionChange@chrome://messenger/content/commandglue.js:350:18
onselect@chrome://messenger/content/messenger.xhtml:1:1
MozTreeChildren/<@chrome://global/content/elements/tree.js:69:28
8 folderDisplay.js:76

@cleidigh
Copy link
Collaborator

@BillH99999
I can reproduce it, moving the columns is all messed up...
as far as the output above those are all errors from quick filters
maybe a good idea for later testing to disable that temporarily
C

@BillH99999
Copy link

@cleidigh,
I'm not sure what you mean by disabling quick filters. I have a quick filter bar displaying, but I did not have any of them selected. I've never really even used this quick filter bar. How would I disable quick filters... just deselect it in the View menu?

@cleidigh
Copy link
Collaborator

don't you have that other extension installed?
it would be under the add-ons

@cleidigh
Copy link
Collaborator

nevermind, I see it's the built-in filter
lots of errors surprisingly
I know I have a problem,just wondering if there is also some interference
let's assume no for now
I can reproduce it so I can do testing

@BillH99999
Copy link

OK... let me know if I can do anything.

@cleidigh
Copy link
Collaborator

thanks I will
happy T day if you celebrate it

@cleidigh
Copy link
Collaborator

cleidigh commented Dec 7, 2020

I just posted b4
bunch of fixes for these lists having to do security issues
shut down is still incomplete
also cannot get custom columns size to be saved

@BillH99999
Copy link

BillH99999 commented Dec 7, 2020

I don't know what is going on, but now I'm having some problems. I added the column Order Received by checking the box and now I can't get rid of it or any other previously selected column. When I try to de-select a column, it changes the up/down arrows on the right to empty squares.

And when I try to add a new folder, the columns are not what is selected in the options. It is not displaying all the columns that have now got the empty squares, but is only adding the Read column (which coincidently also has the empty squares). <

I installed beta 4. In initial testing, this problem seems to be fixed. I'll keep testing to see how things go.

Thanks,
Bill

@cleidigh
Copy link
Collaborator

cleidigh commented Dec 7, 2020

@BillH99999
you must have ESP! super quick responses
the issues with moving columns in the list causing the arrows to disappear
Was one of the main issues I addressed,lots of internal quirks
Christopher

@BillH99999
Copy link

@cleidigh

Actually, I get an email when someone posts on the thread so I go out and see what it is about. This time it was you announcing the new beta, so I downloaded and tested it right away. 😁

I should also add that I had no problems at all selecting or deselecting columns in the default column list.

Bill

@cleidigh
Copy link
Collaborator

cleidigh commented Dec 7, 2020

excellent
I still to figure out how to maintain the column size for custom columns

@jh20001
Copy link

jh20001 commented May 2, 2021

I do miss this one. This is now the only missing add-on in my TB install. A piece of me that is...just an empty space. A space that can't be satisfied by anything else. Just emptiness. sad face :)

@BillH99999
Copy link

The latest beta does support TB 78. See this link:

#95

Bill

@jh20001
Copy link

jh20001 commented May 2, 2021

Ah. How did I miss that. I'll have to give that a shot :)
It's already 6 mo old though. Hopefully, it is still in the plans.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants