Skip to content
This repository has been archived by the owner on Sep 10, 2021. It is now read-only.

Commit

Permalink
Add missing style tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Jamie Snape committed Jun 13, 2014
1 parent 6273fb1 commit 6d3a4b1
Show file tree
Hide file tree
Showing 42 changed files with 452 additions and 117 deletions.
17 changes: 10 additions & 7 deletions core/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,19 @@
add_subdirectory( controllers )
add_subdirectory( models )

add_midas_style_test( StyleCoreAppController ${CMAKE_SOURCE_DIR}/core/AppController.php )
add_midas_style_test( StyleCoreGlobalController ${CMAKE_SOURCE_DIR}/core/GlobalController.php )
add_midas_style_test( StyleCoreGlobalComponent ${CMAKE_SOURCE_DIR}/core/GlobalComponent.php )
add_midas_style_test( StyleCoreApiController ${CMAKE_SOURCE_DIR}/core/ApiController.php )
add_midas_style_test( StyleCoreAppComponent ${CMAKE_SOURCE_DIR}/core/AppComponent.php )
add_midas_style_test( StyleCoreAppFilters ${CMAKE_SOURCE_DIR}/core/AppFilters.php )
add_midas_style_test( StyleCoreAppController ${CMAKE_SOURCE_DIR}/core/AppController.php )
add_midas_style_test( StyleCoreAppForm ${CMAKE_SOURCE_DIR}/core/AppForm.php )
add_midas_style_test( StyleCoreBootstrap ${CMAKE_SOURCE_DIR}/core/Bootstrap.php )
add_midas_style_test( StyleCoreComponentLoader ${CMAKE_SOURCE_DIR}/core/ComponentLoader.php )
add_midas_style_test( StyleCoreConstant ${CMAKE_SOURCE_DIR}/core/constant )
add_midas_style_test( StyleCoreGlobalComponent ${CMAKE_SOURCE_DIR}/core/GlobalComponent.php )
add_midas_style_test( StyleCoreGlobalController ${CMAKE_SOURCE_DIR}/core/GlobalController.php )
add_midas_style_test( StyleCoreInclude ${CMAKE_SOURCE_DIR}/core/include.php )
add_midas_style_test( StyleCoreMidasLoader ${CMAKE_SOURCE_DIR}/core/MidasLoader.php )
add_midas_style_test( StyleCoreNotification ${CMAKE_SOURCE_DIR}/core/Notification.php )
add_midas_style_test( StyleIndex ${CMAKE_SOURCE_DIR}/index.php )


add_midas_style_test( StyleTestsCoreControllers ${CMAKE_SOURCE_DIR}/core/tests/controllers )
add_midas_style_test( StyleTestsCoreModels ${CMAKE_SOURCE_DIR}/core/tests/models )
add_midas_style_test( StyleCoreTestsControllers ${CMAKE_SOURCE_DIR}/core/tests/controllers )
add_midas_style_test( StyleCoreTestsModels ${CMAKE_SOURCE_DIR}/core/tests/models )
2 changes: 1 addition & 1 deletion core/tests/models/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ add_midas_style_test( StyleCoreMIDASDatabaseMongo ${CMAKE_SOURCE_DIR}/core/model
add_midas_style_test( StyleCoreMIDASDatabaseInterface ${CMAKE_SOURCE_DIR}/core/models/MIDASDatabaseInterface.php )
add_midas_style_test( StyleCoreMIDASModel ${CMAKE_SOURCE_DIR}/core/models/MIDASModel.php )
add_midas_style_test( StyleCoreMIDASUpgrade ${CMAKE_SOURCE_DIR}/core/models/MIDASUpgrade.php )
add_midas_style_test( StyleCoreProductionDbProfiler ${CMAKE_SOURCE_DIR}/core/models/prfiler/ProductionDbProfiler.php )
add_midas_style_test( StyleCoreProductionDbProfiler ${CMAKE_SOURCE_DIR}/core/models/profiler/ProductionDbProfiler.php )
15 changes: 10 additions & 5 deletions modules/api/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,15 @@
# limitations under the License.
#=============================================================================

set( module_name api )
to_titlecase( ${module_name} module_name_titlecase )

add_subdirectory( controllers )

# Style
add_midas_style_test( StyleApiControllers ${CMAKE_SOURCE_DIR}/modules/api/controllers )
add_midas_style_test( StyleTestsApiControllers ${CMAKE_SOURCE_DIR}/modules/api/tests/controllers )
add_midas_style_test(StyleApiEnabledNotification
${CMAKE_SOURCE_DIR}/modules/api/library/APIEnabledNotification.php)
add_midas_style_test( Style${module_name_titlecase}AppController ${CMAKE_SOURCE_DIR}/modules/${module_name}/AppController.php )
add_midas_style_test( Style${module_name_titlecase}Constant ${CMAKE_SOURCE_DIR}/modules/${module_name}/constant )
add_midas_style_test( Style${module_name_titlecase}Controllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/controllers )
add_midas_style_test( Style${module_name_titlecase}EnabledNotification ${CMAKE_SOURCE_DIR}/modules/${module_name}/library/APIEnabledNotification.php)
add_midas_style_test( Style${module_name_titlecase}Notification ${CMAKE_SOURCE_DIR}/modules/${module_name}/Notification.php )

add_midas_style_test( Style${module_name_titlecase}TestsControllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/tests/controllers )
13 changes: 9 additions & 4 deletions modules/archive/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,14 @@
# limitations under the License.
#=============================================================================

set( module_name archive )
to_titlecase( ${module_name} module_name_titlecase )

add_subdirectory( controllers )

# Style
add_midas_style_test( StyleArchiveControllers ${CMAKE_SOURCE_DIR}/modules/archive/controllers )
add_midas_style_test( StyleTestsArchiveControllers ${CMAKE_SOURCE_DIR}/modules/archive/tests/controllers )
add_midas_style_test( StyleArchiveNotification ${CMAKE_SOURCE_DIR}/modules/archive/Notification.php )
add_midas_style_test( Style${module_name_titlecase}AppController ${CMAKE_SOURCE_DIR}/modules/${module_name}/AppController.php )
add_midas_style_test( Style${module_name_titlecase}Constant ${CMAKE_SOURCE_DIR}/modules/${module_name}/constant )
add_midas_style_test( Style${module_name_titlecase}Controllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/controllers )
add_midas_style_test( Style${module_name_titlecase}Notification ${CMAKE_SOURCE_DIR}/modules/${module_name}/Notification.php )

add_midas_style_test( Style${module_name_titlecase}TestsControllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/tests/controllers )
34 changes: 15 additions & 19 deletions modules/batchmake/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,27 +17,23 @@
# limitations under the License.
#=============================================================================

option( MIDAS_RUN_BATCHMAKE_TESTS "Should MIDAS run BatchMake tests? Specific configuration is required, see modules/batchmake/tests/README." )
if(MIDAS_RUN_BATCHMAKE_TESTS)
set( module_name batchmake )
to_titlecase( ${module_name} module_name_titlecase )

option( MIDAS_RUN_BATCHMAKE_TESTS "Should MIDAS run BatchMake tests? Specific configuration is required, see modules/batchmake/tests/README." )

# functionality tests will be added by the subdirectories
if(MIDAS_RUN_BATCHMAKE_TESTS)
add_subdirectory( models )
add_subdirectory( controllers )
endif()

# Style tests for code
add_midas_style_test( StyleBatchmakeControllers ${CMAKE_SOURCE_DIR}/modules/batchmake/controllers )
add_midas_style_test( StyleBatchmakeLibrary ${CMAKE_SOURCE_DIR}/modules/batchmake/library )

add_midas_style_test( StyleBatchmakeModels ${CMAKE_SOURCE_DIR}/modules/batchmake/models )
add_midas_style_test( StyleBatchmakeModelsBase ${CMAKE_SOURCE_DIR}/modules/batchmake/models/base )
add_midas_style_test( StyleBatchmakeModelsDAO ${CMAKE_SOURCE_DIR}/modules/batchmake/models/dao )
add_midas_style_test( StyleBatchmakeModelPDO ${CMAKE_SOURCE_DIR}/modules/batchmake/models/pdo )

# Style tests for test code
add_midas_style_test( StyleTestsBatchmakeControllers ${CMAKE_SOURCE_DIR}/modules/batchmake/tests/controllers )
add_midas_style_test( StyleTestsBatchmakeComponents ${CMAKE_SOURCE_DIR}/modules/batchmake/tests/controllers/components )
add_midas_style_test( StyleTestsBatchmakeLibrary ${CMAKE_SOURCE_DIR}/modules/batchmake/tests/library )
add_midas_style_test( StyleTestsBatchmakeModels ${CMAKE_SOURCE_DIR}/modules/batchmake/tests/models )
add_midas_style_test( StyleTestsBatchmakeModelsBase ${CMAKE_SOURCE_DIR}/modules/batchmake/tests/models/base )
add_midas_style_test( Style${module_name_titlecase}AppController ${CMAKE_SOURCE_DIR}/modules/${module_name}/AppController.php )
add_midas_style_test( Style${module_name_titlecase}Constant ${CMAKE_SOURCE_DIR}/modules/${module_name}/constant )
add_midas_style_test( Style${module_name_titlecase}Controllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/controllers )
add_midas_style_test( Style${module_name_titlecase}Library ${CMAKE_SOURCE_DIR}/modules/${module_name}/library )
add_midas_style_test( Style${module_name_titlecase}Models ${CMAKE_SOURCE_DIR}/modules/${module_name}/models )
add_midas_style_test( Style${module_name_titlecase}Notification ${CMAKE_SOURCE_DIR}/modules/${module_name}/Notification.php )

endif()
add_midas_style_test( Style${module_name_titlecase}TestsControllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/tests/controllers )
add_midas_style_test( Style${module_name_titlecase}TestsLibrary ${CMAKE_SOURCE_DIR}/modules/${module_name}/tests/library )
add_midas_style_test( Style${module_name_titlecase}TestsModels ${CMAKE_SOURCE_DIR}/modules/${module_name}/tests/models )
13 changes: 10 additions & 3 deletions modules/cleanup/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,15 @@
# limitations under the License.
#=============================================================================

set( module_name cleanup )
to_titlecase( ${module_name} module_name_titlecase )

add_subdirectory( controllers )

add_midas_style_test( StyleCleanupControllers ${CMAKE_SOURCE_DIR}/modules/cleanup/controllers )
add_midas_style_test( StyleCleanupModels ${CMAKE_SOURCE_DIR}/modules/cleanup/models )
add_midas_style_test( StyleCleanupNotification ${CMAKE_SOURCE_DIR}/modules/cleanup/Notification.php )
add_midas_style_test( Style${module_name_titlecase}AppController ${CMAKE_SOURCE_DIR}/modules/${module_name}/AppController.php )
add_midas_style_test( Style${module_name_titlecase}Constant ${CMAKE_SOURCE_DIR}/modules/${module_name}/constant )
add_midas_style_test( Style${module_name_titlecase}Controllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/controllers )
add_midas_style_test( Style${module_name_titlecase}Models ${CMAKE_SOURCE_DIR}/modules/${module_name}/models )
add_midas_style_test( Style${module_name_titlecase}Notification ${CMAKE_SOURCE_DIR}/modules/${module_name}/Notification.php )

add_midas_style_test( Style${module_name_titlecase}TestsControllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/tests/controllers )
10 changes: 7 additions & 3 deletions modules/comments/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@
# limitations under the License.
#=============================================================================

set( module_name comments )
to_titlecase( ${module_name} module_name_titlecase )

add_midas_style_test( StyleCommentsControllers ${CMAKE_SOURCE_DIR}/modules/comments/controllers )
add_midas_style_test( StyleCommentsModels ${CMAKE_SOURCE_DIR}/modules/comments/models )
add_midas_style_test( StyleCommentsNotification ${CMAKE_SOURCE_DIR}/modules/comments/Notification.php )
add_midas_style_test( Style${module_name_titlecase}AppController ${CMAKE_SOURCE_DIR}/modules/${module_name}/AppController.php )
add_midas_style_test( Style${module_name_titlecase}Constant ${CMAKE_SOURCE_DIR}/modules/${module_name}/constant )
add_midas_style_test( Style${module_name_titlecase}Controllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/controllers )
add_midas_style_test( Style${module_name_titlecase}Models ${CMAKE_SOURCE_DIR}/modules/${module_name}/models )
add_midas_style_test( Style${module_name_titlecase}Notification ${CMAKE_SOURCE_DIR}/modules/${module_name}/Notification.php )
14 changes: 11 additions & 3 deletions modules/communityagreement/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,17 @@
# limitations under the License.
#=============================================================================

set( module_name communityagreement )
to_titlecase( ${module_name} module_name_titlecase )

add_subdirectory( controllers )
add_subdirectory( models )

add_midas_style_test( StyleCommunityagreementNotification ${CMAKE_SOURCE_DIR}/modules/communityagreement/Notification.php )
add_midas_style_test( StyleTestsCommunityagreementControllers ${CMAKE_SOURCE_DIR}/modules/communityagreement/tests/controllers )
add_midas_style_test( StyleTestsCommunityagreementModels ${CMAKE_SOURCE_DIR}/modules/communityagreement/tests/models )
add_midas_style_test( Style${module_name_titlecase}AppController ${CMAKE_SOURCE_DIR}/modules/${module_name}/AppController.php )
add_midas_style_test( Style${module_name_titlecase}Constant ${CMAKE_SOURCE_DIR}/modules/${module_name}/constant )
add_midas_style_test( Style${module_name_titlecase}Controllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/controllers )
add_midas_style_test( Style${module_name_titlecase}Models ${CMAKE_SOURCE_DIR}/modules/${module_name}/models )
add_midas_style_test( Style${module_name_titlecase}Notification ${CMAKE_SOURCE_DIR}/modules/${module_name}/Notification.php )

add_midas_style_test( Style${module_name_titlecase}TestsControllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/tests/controllers )
add_midas_style_test( Style${module_name_titlecase}TestsModels ${CMAKE_SOURCE_DIR}/modules/${module_name}/tests/models )
3 changes: 0 additions & 3 deletions modules/communityagreement/tests/controllers/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,3 @@
#=============================================================================

add_midas_test( CommunityagreementConfigController ConfigControllerTest.php )

# Style
add_midas_style_test( StyleCommunityagreementControllers ${CMAKE_SOURCE_DIR}/modules/communityagreement/controllers )
5 changes: 0 additions & 5 deletions modules/communityagreement/tests/models/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,3 @@
#=============================================================================

add_subdirectory( base )

#Style
add_midas_style_test( StyleCommunityagreementModelsBase ${CMAKE_SOURCE_DIR}/modules/communityagreement/models/base/ )
add_midas_style_test( StyleCommunityagreementModelsPdo ${CMAKE_SOURCE_DIR}/modules/communityagreement/models/pdo/ )
add_midas_style_test( StyleCommunityagreementModelsDao ${CMAKE_SOURCE_DIR}/modules/communityagreement/models/dao/ )
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#=============================================================================

set( module_name dicomanonymize )
to_titlecase( ${module_name} module_name_titlecase )

add_midas_style_test( Style${module_name_titlecase}AppController ${CMAKE_SOURCE_DIR}/modules/${module_name}/AppController.php )
add_midas_style_test( Style${module_name_titlecase}Constant ${CMAKE_SOURCE_DIR}/modules/${module_name}/constant )
add_midas_style_test( Style${module_name_titlecase}Controllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/controllers )
add_midas_style_test( Style${module_name_titlecase}Notification ${CMAKE_SOURCE_DIR}/modules/${module_name}/Notification.php )
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,9 @@
# limitations under the License.
#=============================================================================

add_subdirectory( base )
set( module_name dicomextractor )
to_titlecase( ${module_name} module_name_titlecase )

add_midas_style_test( Style${module_name_titlecase}AppController ${CMAKE_SOURCE_DIR}/modules/${module_name}/AppController.php )
add_midas_style_test( Style${module_name_titlecase}Constant ${CMAKE_SOURCE_DIR}/modules/${module_name}/constant )
add_midas_style_test( Style${module_name_titlecase}Controllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/controllers )
27 changes: 27 additions & 0 deletions modules/dicomserver/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
#=============================================================================
# MIDAS Server
# Copyright (c) Kitware SAS. 26 rue Louis Guérin. 69100 Villeurbanne, FRANCE
# All rights reserved.
# More information http://www.kitware.com
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0.txt
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#=============================================================================

set( module_name dicomserver )
to_titlecase( ${module_name} module_name_titlecase )

add_midas_style_test( Style${module_name_titlecase}AppController ${CMAKE_SOURCE_DIR}/modules/${module_name}/AppController.php )
add_midas_style_test( Style${module_name_titlecase}Constant ${CMAKE_SOURCE_DIR}/modules/${module_name}/constant )
add_midas_style_test( Style${module_name_titlecase}Controllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/controllers )
add_midas_style_test( Style${module_name_titlecase}Models ${CMAKE_SOURCE_DIR}/modules/${module_name}/models )
# add_midas_style_test( Style${module_name_titlecase}Notification ${CMAKE_SOURCE_DIR}/modules/${module_name}/Notification.php ) # FIXME
13 changes: 7 additions & 6 deletions modules/example/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@
# limitations under the License.
#=============================================================================

# Style tests for code
add_midas_style_test( StyleExampleControllers ${CMAKE_SOURCE_DIR}/modules/example/controllers )
add_midas_style_test( StyleExampleModels ${CMAKE_SOURCE_DIR}/modules/example/models )
add_midas_style_test( StyleExampleModelsBase ${CMAKE_SOURCE_DIR}/modules/example/models/base )
add_midas_style_test( StyleExampleModelsDAO ${CMAKE_SOURCE_DIR}/modules/example/models/dao )
add_midas_style_test( StyleExampleModelPDO ${CMAKE_SOURCE_DIR}/modules/example/models/pdo )
set( module_name example )
to_titlecase( ${module_name} module_name_titlecase )

add_midas_style_test( Style${module_name_titlecase}AppController ${CMAKE_SOURCE_DIR}/modules/${module_name}/AppController.php )
add_midas_style_test( Style${module_name_titlecase}Constant ${CMAKE_SOURCE_DIR}/modules/${module_name}/constant )
add_midas_style_test( Style${module_name_titlecase}Controllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/controllers )
add_midas_style_test( Style${module_name_titlecase}Models ${CMAKE_SOURCE_DIR}/modules/${module_name}/models )
13 changes: 10 additions & 3 deletions modules/keyfiles/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,15 @@
# limitations under the License.
#=============================================================================

set( module_name keyfiles )
to_titlecase( ${module_name} module_name_titlecase )

add_subdirectory( controllers )

add_midas_style_test( StyleKeyfilesControllers ${CMAKE_SOURCE_DIR}/modules/keyfiles/controllers )
add_midas_style_test( StyleKeyfilesModels ${CMAKE_SOURCE_DIR}/modules/keyfiles/models )
add_midas_style_test( StyleKeyfilesNotification ${CMAKE_SOURCE_DIR}/modules/keyfiles/Notification.php )
add_midas_style_test( Style${module_name_titlecase}AppController ${CMAKE_SOURCE_DIR}/modules/${module_name}/AppController.php )
add_midas_style_test( Style${module_name_titlecase}Constant ${CMAKE_SOURCE_DIR}/modules/${module_name}/constant )
add_midas_style_test( Style${module_name_titlecase}Controllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/controllers )
add_midas_style_test( Style${module_name_titlecase}Models ${CMAKE_SOURCE_DIR}/modules/${module_name}/models )
add_midas_style_test( Style${module_name_titlecase}Notification ${CMAKE_SOURCE_DIR}/modules/${module_name}/Notification.php )

add_midas_style_test( Style${module_name_titlecase}TestsControllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/tests/controllers )
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,10 @@
# limitations under the License.
#=============================================================================

# Style
add_midas_style_test( StyleThumbnailcreatorControllers ${CMAKE_SOURCE_DIR}/modules/thumbnailcreator/controllers )
set( module_name landingpage )
to_titlecase( ${module_name} module_name_titlecase )

add_midas_style_test( Style${module_name_titlecase}AppController ${CMAKE_SOURCE_DIR}/modules/${module_name}/AppController.php )
add_midas_style_test( Style${module_name_titlecase}Controllers ${CMAKE_SOURCE_DIR}/modules/${module_name}/controllers )
add_midas_style_test( Style${module_name_titlecase}Models ${CMAKE_SOURCE_DIR}/modules/${module_name}/models )
add_midas_style_test( Style${module_name_titlecase}Notification ${CMAKE_SOURCE_DIR}/modules/${module_name}/Notification.php )
Loading

0 comments on commit 6d3a4b1

Please sign in to comment.