This repository was archived by the owner on Sep 10, 2021. It is now read-only.
File tree Expand file tree Collapse file tree 2 files changed +3
-4
lines changed
modules/batchmake/tests/controllers Expand file tree Collapse file tree 2 files changed +3
-4
lines changed Original file line number Diff line number Diff line change @@ -49,7 +49,7 @@ public function setupAndGetConfig()
49
49
MIDAS_BATCHMAKE_SCRIPT_DIR_PROPERTY => $ tmpDir .'/batchmake/tests/script ' ,
50
50
MIDAS_BATCHMAKE_APP_DIR_PROPERTY => $ tmpDir .'/batchmake/tests/bin ' ,
51
51
MIDAS_BATCHMAKE_DATA_DIR_PROPERTY => $ tmpDir .'/batchmake/tests/data ' ,
52
- MIDAS_BATCHMAKE_CONDOR_BIN_DIR_PROPERTY => $ tmpDir .'/batchmake/tests/condorbin ' );//change this with mocks??
52
+ MIDAS_BATCHMAKE_CONDOR_BIN_DIR_PROPERTY => $ tmpDir .'/batchmake/tests/condorbin ' );
53
53
// now make sure these dirs exist
54
54
// later can actually add some stuff to these dirs
55
55
foreach ($ configProps as $ prop => $ dir )
Original file line number Diff line number Diff line change @@ -37,7 +37,6 @@ public function setUp()
37
37
require_once BASE_PATH .'/modules/batchmake/tests/library/ExecutorMock.php ' ;
38
38
$ executor = new Batchmake_ExecutorMock ();
39
39
$ this ->kwBatchmakeComponent = new Batchmake_KWBatchmakeComponent ($ this ->setupAndGetConfig (), $ executor );
40
- // $this->kwBatchmakeComponent = new Batchmake_KWBatchmakeComponent($this->setupAndGetConfig());
41
40
}
42
41
}
43
42
@@ -53,8 +52,8 @@ public function testIsConfigCorrect()
53
52
// now make a change to something that shouldn't work
54
53
$ badConfigVals = $ this ->setupAndGetConfig ();
55
54
$ badConfigVals [MIDAS_BATCHMAKE_DATA_DIR_PROPERTY ] = '/unlikely/to/work/right ' ;
56
- $ badKwBatchmakeComponent = new Batchmake_KWBatchmakeComponent ($ badConfigVals );//BASE_PATH.'/modules/batchmake/tests/configs/module.local.ini');
57
- $ this ->assertFalse ($ badKwBatchmakeComponent ->isConfigCorrect ());//$badConfigVals));
55
+ $ badKwBatchmakeComponent = new Batchmake_KWBatchmakeComponent ($ badConfigVals );
56
+ $ this ->assertFalse ($ badKwBatchmakeComponent ->isConfigCorrect ());
58
57
}
59
58
60
59
/**
You can’t perform that action at this time.
0 commit comments