Prevent bad commits deploying. (git) #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the event of a fatal error occuring when trying to add content to git for commit, you end up pushing a blank commit to the git respository. This is a change which halts the push to a git repository so you don't accidentally take down your website.
|
This looks like a great change 👍 I'll review it later on. Thanks. |
|
Looks as a cool addition, you short on time could merge this please? |
karlfreeman
added a commit
that referenced
this pull request
Nov 21, 2014
Prevent bad commits deploying. (git)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for building this handy gem. I don't know if the following change is worth merging, as it only covers 3 system calls and there isn't a test suite so skipped over writing any, but I wanted to raise awareness of an issue when you encounter a fatal error with git.
Using
git add -A, if git encounters a fatal error, it will output to stderr, but won't halt the deployment from happening. The result of this is that you end up pushing nothing to your git repository, and blatting your live website in the process. This is just a simple guard to halt the deploy from completing if something goes wrong.