Add support for encoded path #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decode url path before matching routes
shadowhand
approved these changes
Apr 1, 2019
|
I really like this! @oscarotero what do you think? Seems like a simple fix and a win for non-English speakers. |
|
@shadowhand I like it too. @smalot Many thanks for this. |
oscarotero
added a commit
that referenced
this pull request
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decode url path before matching routes to work with any path with accent.
Example
Which should decoded as:
This is also done in Symfony:
https://github.com/symfony/symfony/blob/4.2/src/Symfony/Component/Routing/Matcher/UrlMatcher.php#L87