Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Rename to Request-Id #2

Open
marijn opened this issue Aug 28, 2017 · 3 comments
Open

RFC: Rename to Request-Id #2

marijn opened this issue Aug 28, 2017 · 3 comments

Comments

@marijn
Copy link

marijn commented Aug 28, 2017

Thanks for making an effort in building up the PSR middleware ecosystem.

I was wondering why you choose to name this package UUID. It seems its more about assigning identity to individual requests than about the particular ID used.

@oscarotero
Copy link
Member

This middleware not only identify the request but also the response returned, so it's usefult for debug purposes. The UUID specification guarantee uniqueness across space and time, so I think it's a good name to identify a request->response cycle.

Thoughts @middlewares/contributors ?

@shadowhand
Copy link
Member

shadowhand commented May 14, 2018

I think it would be good to rename this package, or have a separate middlewares/request-identity package that would allow for both UUID and custom identifiers via interface:

interface RequestIdentityInterface
{
    public function getRequestIdentity(Request $request): string;
}

This interface would be useful in situations where the request identity could be provided via a header or other other means.

@oscarotero
Copy link
Member

I don't know if it's possible to rename this package without break other things (like dependents). If it's problematic, a new package that deprecates this could be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants