Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 8 #8

Closed
arokettu opened this issue Nov 24, 2020 · 1 comment
Closed

Support PHP 8 #8

arokettu opened this issue Nov 24, 2020 · 1 comment

Comments

@arokettu
Copy link
Contributor

Tests almost pass, there is one problem with the test itself:

$this->assertNotFalse(strpos((string) $response->getBody(), 'Undefined variable: b'));

The message has changed and now contains dollar sign: PHP Warning: Undefined variable $b

Obvious blocker as I understand: middlewares/utils#22
@arokettu arokettu mentioned this issue Nov 25, 2020
Merged
@oscarotero
Copy link
Member

Thanks. I just released 2.0.1 with support for PHP 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oscarotero @arokettu