Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serverless logger close when runtime stop #1022

Merged
merged 3 commits into from
May 6, 2021

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gitpod-io
Copy link

gitpod-io bot commented May 1, 2021

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.10%. Comparing base (5735ccc) to head (058736f).
Report is 206 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ckages-serverless/runtime-engine/src/lib/logger.ts 61.53% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #1022      +/-   ##
==========================================
+ Coverage   85.97%   86.10%   +0.12%     
==========================================
  Files         213      213              
  Lines        8245     8253       +8     
  Branches     1613     1616       +3     
==========================================
+ Hits         7089     7106      +17     
+ Misses       1107     1098       -9     
  Partials       49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czy88840616 czy88840616 merged commit 28548da into 2.x May 6, 2021
@czy88840616 czy88840616 deleted the fix_runtime_logger_close branch May 6, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants