Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support EventSubscriberModel with provide #1095

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Conversation

czy88840616
Copy link
Member

related: #1037

@gitpod-io
Copy link

gitpod-io bot commented Jun 12, 2021

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2021

Codecov Report

Merging #1095 (12d9faf) into 2.x (f6f4af9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #1095      +/-   ##
==========================================
+ Coverage   85.68%   85.69%   +0.01%     
==========================================
  Files         221      221              
  Lines        8806     8811       +5     
  Branches     1707     1708       +1     
==========================================
+ Hits         7545     7551       +6     
+ Misses       1200     1199       -1     
  Partials       61       61              
Impacted Files Coverage Δ
packages/orm/src/configuration.ts 98.88% <100.00%> (+0.06%) ⬆️
packages/orm/src/index.ts 68.62% <100.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f4af9...12d9faf. Read the comment docs.

Copy link
Contributor

@kurten kurten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czy88840616 czy88840616 merged commit 05431d2 into 2.x Jun 14, 2021
@czy88840616 czy88840616 deleted the support_orm_event branch June 14, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants