Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support hostname to http-listening #1186

Merged
merged 5 commits into from
Jul 29, 2021

Conversation

tkvern
Copy link
Contributor

@tkvern tkvern commented Jul 29, 2021

Checklist
  • npm test passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • web
  • web-koa
  • web-exporess
Description of change

add support hostname to http server listening, then user can custom hostname by self

@gitpod-io
Copy link

gitpod-io bot commented Jul 29, 2021

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2021

Codecov Report

Merging #1186 (6141acc) into 2.x (4405caf) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #1186      +/-   ##
==========================================
- Coverage   85.52%   85.46%   -0.06%     
==========================================
  Files         221      221              
  Lines        8834     8840       +6     
  Branches     1758     1696      -62     
==========================================
  Hits         7555     7555              
- Misses       1215     1222       +7     
+ Partials       64       63       -1     
Impacted Files Coverage Δ
packages/web-express/src/framework.ts 71.42% <0.00%> (-1.30%) ⬇️
packages/web-koa/src/framework.ts 73.77% <0.00%> (-1.23%) ⬇️
packages/web/src/framework/singleProcess.ts 67.12% <0.00%> (-1.90%) ⬇️
...ckages-serverless/runtime-engine/src/lib/logger.ts 74.41% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4405caf...6141acc. Read the comment docs.

@czy88840616 czy88840616 merged commit 6f8356f into midwayjs:2.x Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants