fix(deps): add terser to depenencies #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node.js v8 still need to be supported in midway v1
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
=======================================
Coverage 89.56% 89.56%
=======================================
Files 36 36
Lines 843 843
Branches 48 48
=======================================
Hits 755 755
Misses 78 78
Partials 10 10
Continue to review full report at Codecov.
|
czy88840616
approved these changes
Feb 17, 2020
czy88840616
pushed a commit
that referenced
this pull request
Feb 17, 2020
fix(deps): add terser to depenencies (#390) * fix(deps): add terser to depenencies * fix(build): prevent from using fs.promises Node.js v8 still need to be supported in midway v1
czy88840616
pushed a commit
that referenced
this pull request
Feb 17, 2020
* fix(deps): add terser to depenencies * fix(build): prevent from using fs.promises Node.js v8 still need to be supported in midway v1 (cherry picked from commit e6da77e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
midway-bin