fix: ts build cwd #396
Merged
fix: ts build cwd #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #396 +/- ##
==========================================
+ Coverage 86.48% 86.56% +0.07%
==========================================
Files 77 77
Lines 2057 2054 -3
Branches 124 124
==========================================
- Hits 1779 1778 -1
+ Misses 256 254 -2
Partials 22 22
Continue to review full report at Codecov.
|
czy88840616
approved these changes
Feb 20, 2020
Lellansin
reviewed
Feb 20, 2020
packages/midway-bin/lib/cmd/build.js
Outdated
| if (/\.tsx?$/.test(item)) { | ||
| args.push(item); | ||
| } | ||
| args.push(item); |
There was a problem hiding this comment.
前面的 files 和 globby 出来的文件可能有重复.. 不过测试了一下 tsc 也能处理
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ts build cwd