feat: MidwayRequestContainer 增加泛型标注 #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
要不直接搞2.0里吧。。 |
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
=======================================
Coverage 89.56% 89.56%
=======================================
Files 36 36
Lines 843 843
Branches 48 48
=======================================
Hits 755 755
Misses 78 78
Partials 10 10
Continue to review full report at Codecov.
|
|
这个功能应该和版本无关，merge 之后1.x和2.x都行吧 @czy88840616 |
|
也可以。。就是我要cherry-pick。。 |
kurten
reviewed
Feb 29, 2020
| @@ -43,7 +43,7 @@ export class MidwayRequestContainer extends MidwayContainer { | |||
| } | |||
| } | |||
|
|
|||
| async getAsync<T>(identifier: any, args?: any) { | |||
| async getAsync<T = any>(identifier: any, args?: any) :Promise<T> { | |||
There was a problem hiding this comment.
- TypeScript 中 T 默认就是any，这里没有必要加吧
- 默认就是返回 T 类型的
There was a problem hiding this comment.
从 typescript 3.5.0 开始默认是 unknown 类型的。
There was a problem hiding this comment.
默认是 unknown，所以如果不加 T=any 的话，很多之前的老代码都可能会报错。 @kurten
There was a problem hiding this comment.
any 既是 top 顶级类型也是 bottom 最下级类型，而 unknown 只是 bottom 最下级类型。
czy88840616
approved these changes
Mar 1, 2020
czy88840616
pushed a commit
that referenced
this pull request
Mar 1, 2020
feat: MidwayRequestContainer 增加泛型标注 (#407)
czy88840616
pushed a commit
that referenced
this pull request
Mar 5, 2020
(cherry picked from commit daee9d3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change