Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 2.x lifecycle #414

Merged
merged 11 commits into from
Mar 6, 2020
Merged

feat: 2.x lifecycle #414

merged 11 commits into from
Mar 6, 2020

Conversation

kurten
Copy link
Contributor

@kurten kurten commented Mar 5, 2020

  • 增加 lifecycle 能力以及测试用例

@codecov-io
Copy link

codecov-io commented Mar 5, 2020

Codecov Report

Merging #414 into 2.x will increase coverage by 3.77%.
The diff coverage is 85%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x     #414      +/-   ##
==========================================
+ Coverage   89.98%   93.75%   +3.77%     
==========================================
  Files          79       80       +1     
  Lines        2187     2195       +8     
  Branches      128      128              
==========================================
+ Hits         1968     2058      +90     
+ Misses        198      112      -86     
- Partials       21       25       +4
Impacted Files Coverage Δ
packages/midway-core/src/interface.ts 100% <ø> (ø) ⬆️
...ages/midway-core/src/context/applicationContext.ts 97.75% <ø> (-0.21%) ⬇️
packages/midway-core/src/context/container.ts 100% <100%> (ø) ⬆️
packages/midway-decorator/src/common/constant.ts 100% <100%> (ø) ⬆️
...kages/midway-decorator/src/annotation/objectDef.ts 90.9% <100%> (+44.75%) ⬆️
...ackages/midway-core/src/context/midwayContainer.ts 99.2% <100%> (+0.87%) ⬆️
...ackages/midway-decorator/src/annotation/provide.ts 100% <100%> (+11.11%) ⬆️
packages/midway-decorator/src/annotation/index.ts 100% <100%> (ø) ⬆️
packages/midway-decorator/src/annotation/inject.ts 100% <100%> (+82.6%) ⬆️
...kages/midway-decorator/src/annotation/lifecycle.ts 100% <100%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 746238d...e2c726b. Read the comment docs.

@czy88840616 czy88840616 self-requested a review March 5, 2020 12:11
@czy88840616 czy88840616 changed the title 2.x lifecycle feat: 2.x lifecycle Mar 6, 2020
@czy88840616 czy88840616 merged commit 7313ab8 into 2.x Mar 6, 2020
@czy88840616 czy88840616 deleted the 2.x_lifecycle branch March 6, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants