Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: configuration use package name #485

Merged
merged 3 commits into from
May 6, 2020
Merged

fix: configuration use package name #485

merged 3 commits into from
May 6, 2020

Conversation

kurten
Copy link
Contributor

@kurten kurten commented May 5, 2020

  • midway-web cov 100%

@gitpod-io
Copy link

gitpod-io bot commented May 5, 2020 •
edited
Loading

@codecov-io
Copy link

codecov-io commented May 5, 2020 •
edited
Loading

Codecov Report

Merging #485 into 2.x will increase coverage by 1.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x     #485      +/-   ##
==========================================
+ Coverage   96.74%   97.77%   +1.03%     
==========================================
  Files          83       83              
  Lines        2702     2702              
  Branches      199      199              
==========================================
+ Hits         2614     2642      +28     
+ Misses         88       60      -28
Impacted Files Coverage Δ
packages/midway-web/src/loader/webLoader.ts 100.00% <0.00%> (+5.16%) ⬆️
packages/midway-web/config/config.default.js 100.00% <0.00%> (+5.88%) ⬆️
packages/midway-web/src/midway.ts 100.00% <0.00%> (+19.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ddfc38...1a1f89a. Read the comment docs.

@kurten kurten changed the title WIP: add test case cov web case 100 & configuration use package name May 6, 2020
@czy88840616 czy88840616 changed the title web case 100 & configuration use package name fix: configuration use package name May 6, 2020
@czy88840616 czy88840616 merged commit a00cb18 into 2.x May 6, 2020
@czy88840616 czy88840616 deleted the web_case_100 branch May 6, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czy88840616 czy88840616 czy88840616 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kurten @codecov-io @czy88840616