Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 2.x extends bug #498

Merged
merged 5 commits into from
Jun 16, 2020
Merged

fix: 2.x extends bug #498

merged 5 commits into from
Jun 16, 2020

Conversation

kurten
Copy link
Contributor

@kurten kurten commented May 27, 2020

  • 修复 controller 继承导致 router 覆盖 bug

@gitpod-io
Copy link

gitpod-io bot commented May 27, 2020

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2020

Codecov Report

Merging #498 into 2.x will decrease coverage by 0.08%.
The diff coverage is 94.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x     #498      +/-   ##
==========================================
- Coverage   97.78%   97.69%   -0.09%     
==========================================
  Files          83       83              
  Lines        2705     2733      +28     
  Branches      199      202       +3     
==========================================
+ Hits         2645     2670      +25     
- Misses         60       63       +3     
Impacted Files Coverage Δ
...es/midway-decorator/src/common/decoratorManager.ts 97.95% <94.44%> (-2.05%) ⬇️
...kages/midway-decorator/src/annotation/objectDef.ts 100.00% <100.00%> (ø)
packages/midway-web/src/index.ts 100.00% <0.00%> (ø)
packages/midway-core/src/index.ts 100.00% <0.00%> (ø)
packages/midway-mock/src/index.ts 100.00% <0.00%> (ø)
packages/midway-decorator/src/index.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20db86a...770f174. Read the comment docs.

@czy88840616 czy88840616 changed the title 2.x extends bug fix: 2.x extends bug Jun 16, 2020
@czy88840616 czy88840616 merged commit 19ec029 into 2.x Jun 16, 2020
@czy88840616 czy88840616 deleted the 2.x_extends_bug branch June 16, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants