Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move @types/joi to dependencies #638

Merged
merged 2 commits into from
Sep 16, 2020
Merged

fix: move @types/joi to dependencies #638

merged 2 commits into from
Sep 16, 2020

Conversation

zhangyuang
Copy link
Contributor

@zhangyuang zhangyuang commented Sep 16, 2020

由于 decorator/src/annotation/rule.ts export 了 joi 这个库的类型。导致实际生产环境需要安装 @types/joi
否则tsc 构建时会报错,因为@types/joidevdependencies导致运行环境并没有安装这个依赖
version:

"@midwayjs/decorator": "^2.0.0",
"typescript": "^4.0.2" // 3.x版本也可复现

最简复现仓库:https://github.com/zhangyuang/midway-decorator-error
复现步骤

$ yarn
$ npx tsc

image

image

@gitpod-io
Copy link

gitpod-io bot commented Sep 16, 2020

@czy88840616 czy88840616 merged commit 7c31164 into midwayjs:2.x Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants