Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement optional dep for amqplib in mock package #654

Merged
merged 4 commits into from
Oct 1, 2020

Conversation

czy88840616
Copy link
Member

@czy88840616 czy88840616 commented Oct 1, 2020

remove amqplib package in @midwayjs/mock and add try cache block when other require it.

@gitpod-io
Copy link

gitpod-io bot commented Oct 1, 2020

@czy88840616 czy88840616 changed the title Fix optional dep fix: implement optional dep for amqplib in mock package Oct 1, 2020
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2020

Codecov Report

Merging #654 into 2.x will decrease coverage by 0.12%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x     #654      +/-   ##
==========================================
- Coverage   84.15%   84.02%   -0.13%     
==========================================
  Files          96       96              
  Lines        3963     3976      +13     
  Branches      648      652       +4     
==========================================
+ Hits         3335     3341       +6     
- Misses        615      622       +7     
  Partials       13       13              
Impacted Files Coverage Δ
packages/bootstrap/src/bootstrap.ts 70.31% <0.00%> (ø)
packages/decorator/src/common/constant.ts 100.00% <ø> (ø)
...ges/decorator/src/microservice/rabbitmqConsumer.ts 28.57% <ø> (ø)
packages/web/src/config/plugin.ts 100.00% <ø> (ø)
packages/mock/src/client/rabbitMQ.ts 9.23% <17.85%> (+0.76%) ⬆️
packages/decorator/src/web/response.ts 21.42% <50.00%> (-0.80%) ⬇️
packages/rabbitmq/src/mq.ts 45.45% <77.77%> (+0.74%) ⬆️
packages/core/src/context/container.ts 100.00% <100.00%> (ø)
packages/core/src/context/midwayContainer.ts 94.21% <100.00%> (ø)
packages/core/src/util/isClass.ts 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abae8f2...246fdaa. Read the comment docs.

@czy88840616 czy88840616 merged commit 3319872 into 2.x Oct 1, 2020
@czy88840616 czy88840616 deleted the fix_optional_dep branch October 1, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants