Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: monorepo use different cwd #752

Merged
merged 1 commit into from
Dec 12, 2020
Merged

Conversation

czy88840616
Copy link
Member

@czy88840616 czy88840616 commented Dec 12, 2020

修复在不同的 monorepo cwd 场景下,启动 eggjs 的问题。

related: eggjs/egg#4274

@gitpod-io
Copy link

gitpod-io bot commented Dec 12, 2020

@codecov-io
Copy link

codecov-io commented Dec 12, 2020

Codecov Report

Merging #752 (f7288ee) into 2.x (af7a462) will increase coverage by 0.48%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x     #752      +/-   ##
==========================================
+ Coverage   85.99%   86.47%   +0.48%     
==========================================
  Files         144      144              
  Lines        5906     5902       -4     
  Branches     1094     1092       -2     
==========================================
+ Hits         5079     5104      +25     
+ Misses        792      766      -26     
+ Partials       35       32       -3     
Impacted Files Coverage Δ
packages/web/src/base.ts 89.13% <100.00%> (-0.31%) ⬇️
packages/web/config/config.default.js 100.00% <0.00%> (+6.25%) ⬆️
packages/web/app.js 78.12% <0.00%> (+9.37%) ⬆️
packages/web/src/devFramework.ts 66.66% <0.00%> (+22.22%) ⬆️
packages/web/src/framework.ts 87.83% <0.00%> (+25.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af7a462...f7288ee. Read the comment docs.

@czy88840616 czy88840616 self-assigned this Dec 12, 2020
@czy88840616 czy88840616 merged commit cb3ba35 into 2.x Dec 12, 2020
@czy88840616 czy88840616 deleted the fix_monorepo_differennt_cwd branch December 12, 2020 08:57
@waitingsong
Copy link
Member

v2.5.4 版本下 monorep+egg 正常了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants