Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable coreLogger info console output in local env #829

Merged
merged 6 commits into from
Jan 28, 2021

Conversation

czy88840616
Copy link
Member

@czy88840616 czy88840616 commented Jan 27, 2021

  • 1、本地日志还是输出太多,和默认 egg 启动保持一致,不再输出 core logger 的日志。如有需求,可以使用 app.logger 或者调整日志解决
  • 2、midway logger 之前未适配 egg 部分配置
  • 3、修复 contextLogger 未覆盖成功的错误

@gitpod-io
Copy link

gitpod-io bot commented Jan 27, 2021

@codecov-io
Copy link

codecov-io commented Jan 27, 2021

Codecov Report

Merging #829 (f2d4fcd) into 2.x (7941f87) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.x     #829   +/-   ##
=======================================
  Coverage   86.98%   86.99%           
=======================================
  Files         170      169    -1     
  Lines        6716     6721    +5     
  Branches     1291     1296    +5     
=======================================
+ Hits         5842     5847    +5     
- Misses        842      843    +1     
+ Partials       32       31    -1     
Impacted Files Coverage Δ
packages/web-express/src/framework.ts 71.32% <ø> (ø)
packages/web-koa/src/framework.ts 73.28% <100.00%> (ø)
packages/web/src/framework/web.ts 95.18% <100.00%> (+0.11%) ⬆️
packages/web/src/logger.ts 89.90% <100.00%> (+0.38%) ⬆️
...ckages-serverless/runtime-engine/src/lib/logger.ts 73.52% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7941f87...f2d4fcd. Read the comment docs.

@czy88840616 czy88840616 changed the title refactor: disable coreLogger info console output in local env fix: disable coreLogger info console output in local env Jan 28, 2021
@czy88840616 czy88840616 merged commit adaaaea into 2.x Jan 28, 2021
@czy88840616 czy88840616 deleted the remove_coreLogger_output branch January 28, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants