Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: egg socket io missing session middleware #835

Merged
merged 3 commits into from
Feb 2, 2021
Merged

Conversation

czy88840616
Copy link
Member

@czy88840616 czy88840616 commented Jan 30, 2021

fix: #825

@gitpod-io
Copy link

gitpod-io bot commented Jan 30, 2021

@czy88840616 czy88840616 changed the title fix: fix egg socket io missing session middleware fix: egg socket io missing session middleware Jan 30, 2021
@codecov-io
Copy link

codecov-io commented Jan 30, 2021

Codecov Report

Merging #835 (346f510) into 2.x (11716fe) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x     #835      +/-   ##
==========================================
+ Coverage   86.99%   87.02%   +0.02%     
==========================================
  Files         169      169              
  Lines        6722     6734      +12     
  Branches     1297     1300       +3     
==========================================
+ Hits         5848     5860      +12     
  Misses        843      843              
  Partials       31       31              
Impacted Files Coverage Δ
packages/web/app.js 81.08% <100.00%> (+1.66%) ⬆️
packages/web/src/base.ts 91.71% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11716fe...346f510. Read the comment docs.

@czy88840616 czy88840616 merged commit 6e605a1 into 2.x Feb 2, 2021
@czy88840616 czy88840616 deleted the fix_socket_io branch February 2, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

midway 2.x 中使用egg-socket.io有问题
2 participants