Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ctx logger overwrite in egg extend #846

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Conversation

czy88840616
Copy link
Member

@czy88840616 czy88840616 commented Feb 7, 2021

修复egg 框架继承的情况下,提前使用 ctx.logger 输出报错 "[winston] Unknown logger level: INFO" 的情况。错误如截图。

image

@gitpod-io
Copy link

gitpod-io bot commented Feb 7, 2021

@codecov-io
Copy link

codecov-io commented Feb 7, 2021

Codecov Report

Merging #846 (ddd4249) into 2.x (0051d07) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x     #846      +/-   ##
==========================================
+ Coverage   86.96%   86.99%   +0.02%     
==========================================
  Files         169      170       +1     
  Lines        6761     6776      +15     
  Branches     1309     1311       +2     
==========================================
+ Hits         5880     5895      +15     
  Misses        851      851              
  Partials       30       30              
Impacted Files Coverage Δ
packages/web/agent.js 100.00% <100.00%> (ø)
packages/web/app.js 82.50% <100.00%> (+0.92%) ⬆️
packages/web/app/extend/agent.js 100.00% <100.00%> (ø)
packages/web/src/framework/web.ts 95.29% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0051d07...ddd4249. Read the comment docs.

@czy88840616 czy88840616 merged commit a9d7a0d into 2.x Feb 8, 2021
@czy88840616 czy88840616 deleted the fix_ctx_logger_overwrite branch February 8, 2021 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants