-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error dialog self-closes #1658
Comments
that's a good point, the only problem is that some people might not want a modal to block their whole flow just because of a warning. so need to find a way to still show it as a toast, but not auto-close it after x seconds. |
ok will remove the timer in the toast if there are warnings |
I'd sure prefer my flow blocked rather than miss an almost certain failure warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have a lot of issues to go through, so in order to make it easier for me to help you, I ask that you please try these things first
Operating System
Windows 10
Steps to reproduce
Merge damaged files
Expected behavior
A while back I complained about it silently failing on some files. This was soon fixed, upon completion it gives a warning about the file size not being as expected. Unfortunately, this shows up on the merge complete notice--which soon self-closes. That means if you're not paying attention to it you won't see the error--come back to it and there's absolutely no difference between merge successful and merge unsuccessful.
If there's a warning leave the box open!
Actual behavior
See expected behavior.
Share log
Not relevant
The text was updated successfully, but these errors were encountered: