Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the Non-Admin Restore is correctly handled for the Backup that was not completed #137

Open
mpryc opened this issue Jan 9, 2025 · 0 comments

Comments

@mpryc
Copy link
Collaborator

mpryc commented Jan 9, 2025

The reason for logging this issue is to ensure we won't miss important workflow:

  1. Create Non-Admin Backup that is improper (for example wrong s3 creds)
  2. Create Restore object that points to the improper Non-Admin Backup

In the above scenario the Non-Admin Restore object should reconcile with some error condition.

It was observed in the console that the reconcile for such cases got the Error within logs in the test run, but I did not check the Restore object itself if it's correctly handled, that's why logging this bug to not miss it:

  2025-01-09T13:02:22+01:00	ERROR	Reconciler error	{"controller": "nonadminrestore", "controllerGroup": "oadp.openshift.io", "controllerKind": "NonAdminRestore", "NonAdminRestore": {"name":"non-admin-restore-object-1","namespace":"test-non-admin-restore-reconcile-full-1"}, "namespace": "test-non-admin-restore-reconcile-full-1", "name": "non-admin-restore-object-1", "reconcileID": "11164cf6-f4f8-40df-8bea-13dce5d01763", "error": "terminal error: NonAdminRestore spec.restoreSpec.backupName is invalid: NonAdminBackup is not ready to be restored"}
@mpryc mpryc added the test-case label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant