Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs in examples #211

Closed
galcik opened this issue May 22, 2016 · 2 comments
Closed

Bugs in examples #211

galcik opened this issue May 22, 2016 · 2 comments
Labels
bug 🐛 a not intended feature need_confirmation 🧷 bug report must be confirmed by a second person, write if you have the same issue

Comments

@galcik
Copy link

galcik commented May 22, 2016

examples/MifareClassicValueBlock/MifareClassicValueBlock.ino, lines 168-170: && should be replaced with || Indeed, rewrite of sector trailer is required if any of the access bits is changed.

examples/ReadNUID/ReadNUID.ino, line 42: nuidPICC[3] should be replaced with nuidPICC[4] as the size of NUID is 4 bytes.
@Rotzbua
Copy link
Collaborator

Rotzbua commented May 28, 2016

Feel free to make a pull request.

@Rotzbua Rotzbua added bug 🐛 a not intended feature need_feedback ↩️ awaiting feedback from people need_confirmation 🧷 bug report must be confirmed by a second person, write if you have the same issue and removed need_feedback ↩️ awaiting feedback from people labels Aug 25, 2016
@omersiar
Copy link
Contributor

omersiar commented Nov 14, 2016 •
edited
Loading

Using OR operator "double dash" makes more sense. nuidPICC byte array should be 4 byte, made changes to code. They will be there in next release I guess.

Thank you @galcik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 a not intended feature need_confirmation 🧷 bug report must be confirmed by a second person, write if you have the same issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@omersiar @Rotzbua @galcik