Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing transition utils #120

Closed
leoeuclids opened this issue Jan 31, 2023 · 7 comments · Fixed by #138
Closed

Missing transition utils #120

leoeuclids opened this issue Jan 31, 2023 · 7 comments · Fixed by #138

Comments

@leoeuclids
Copy link

leoeuclids commented Jan 31, 2023

Description

Importing functions from transition utils, like described in the docs, doesn't work after version 4.0.0.
I'm not sure if this is intended, but if someone can confirm this should still be working, I can open a PR to fix it.

How to reproduce

  1. Add import { nextTick } from 'ember-css-transitions/utils/transition-utils';
  2. Run ember s
  3. Should result in webpack returned errors to ember-auto-import

Source

The utils folder is not being defined as a public entry point in the rollup config file.

@miguelcobain
Copy link
Owner

I suspect the change to v2 addon format.

@SergeAstapov do you know why this happens?

@tcjr
Copy link
Contributor

tcjr commented Mar 16, 2024

I'm seeing this in a project where I'm updating dependencies. It looks like the utils aren't in the NPM package.

https://www.npmjs.com/package/ember-css-transitions?activeTab=code

@SergeAstapov
Copy link
Collaborator

I suspect the change to v2 addon format.

@SergeAstapov do you know why this happens?

ah yes, we didn't list /utils as public entry point hence it's not available.
Thanks @tcjr for the PR!

@matthewhartstonge
Copy link

👋 just hit this with v4.4.0.
Are we able to get a release including the bug fix above? 🙏

@matthewhartstonge
Copy link

matthewhartstonge commented Oct 2, 2024

Worked out that in v4.4 these utils are being inlined, but not exported from:

import { nextTick } from 'ember-css-transitions/utils/transition-utils';

To:

import { nextTick } from 'ember-css-transitions/modifiers/css-transition';

@matthewhartstonge
Copy link

So those functions, even though they are being inlined into /modifiers/css-transition, aren't exported.

This is definitely a bug.

The documentation also mentions that we should be able to pull in the utils.

@miguelcobain or @SergeAstapov are we able to get #138 merged and released?

@SergeAstapov
Copy link
Collaborator

The fix now released as v4.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants