-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing transition utils #120
Comments
I suspect the change to v2 addon format. @SergeAstapov do you know why this happens? |
I'm seeing this in a project where I'm updating dependencies. It looks like the utils aren't in the NPM package. https://www.npmjs.com/package/ember-css-transitions?activeTab=code |
ah yes, we didn't list |
👋 just hit this with |
Worked out that in import { nextTick } from 'ember-css-transitions/utils/transition-utils'; To: import { nextTick } from 'ember-css-transitions/modifiers/css-transition'; |
So those functions, even though they are being inlined into This is definitely a bug. The documentation also mentions that we should be able to pull in the utils. @miguelcobain or @SergeAstapov are we able to get #138 merged and released? |
The fix now released as v4.4.1 |
Description
Importing functions from transition utils, like described in the docs, doesn't work after version 4.0.0.
I'm not sure if this is intended, but if someone can confirm this should still be working, I can open a PR to fix it.
How to reproduce
import { nextTick } from 'ember-css-transitions/utils/transition-utils';
ember s
webpack returned errors to ember-auto-import
Source
The utils folder is not being defined as a public entry point in the rollup config file.
The text was updated successfully, but these errors were encountered: