Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with apps that use a strict or helper #636

Closed
runspired opened this issue Mar 26, 2021 · 2 comments
Closed

Not compatible with apps that use a strict or helper #636

runspired opened this issue Mar 26, 2021 · 2 comments

Comments

@runspired
Copy link
Contributor

Had a fun debugging session tonight 😭

My app defines an or helper that does not come from ember-truth-helpers. This or helper is strict vs loose (meaning that it casts the return value to a boolean rather than returning a falsey or truthy value).

Turns out that the component assignment is depending on the loose or

{{#each this.componentsToYield as |c|}}
      {{ember-leaflet-assign-to
        components
        key=(or c.as c.name)
        value=(component c.name parent=this node=Node)
        onChange=this.mergeComponents}}
    {{/each}}
@miguelcobain
Copy link
Owner

I see. Perhaps we should include our own "loose" or helper.

@miguelcobain
Copy link
Owner

This fix was released on 5.0.0-beta.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants