Update paper-card for 1.0 #338
Conversation
| @@ -2,6 +2,6 @@ import Ember from 'ember'; | |||
| import FlexMixin from '../mixins/flex-mixin'; | |||
|
|
|||
| export default Ember.Component.extend(FlexMixin, { | |||
There was a problem hiding this comment.
Let's destructure stuff and not use FlexMixin since it will be removed.
|
What do you mean by
and
? |
|
Also, please rebase to have the latest upstream changes. They will fix the build errors of this PR. |
| @@ -0,0 +1,3 @@ | |||
| <md-card-actions class="{{class}} layout-{{layout}} layout-align-{{layoutAlignClassName}}"> | |||
There was a problem hiding this comment.
I don't think we need to provide specific layout and layoutAlign properties.
Won't these flex classes be part of the public API?
joukevandermaas
force-pushed
the
wip/v1.0.0
branch
from
9df1d3a to
6b20ffc
Compare
- Add support for headers & avatars - Use contextual components (but not mandatory) - Create components for actions, headers, titles, etc.
joukevandermaas
changed the title
|
@miguelcobain please review again, now that I think all the changes are in. I rebased on the latest upstream changes and 08edccb contains the image/media cards I was referring to. I can squash when you're done with the review, although I believe GitHub supports it from the web UI now. |
|
👍 |
|
Unfortunately GitHub doesn't seem to allow you to change the base branch you are PRing against and automatically closes any PRs when the base branch is deleted. Moving forward we are using the |
Add support for 'dark' (colored) cards(not in Angular Material 1.06)